Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Save to RXN for pathway reactions #2234

Closed
ivanmaslow opened this issue Aug 15, 2024 · 3 comments
Closed

Update Save to RXN for pathway reactions #2234

ivanmaslow opened this issue Aug 15, 2024 · 3 comments
Assignees
@even1024
Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue
Milestone
Indigo-1.25.0-rc.1

Comments

@ivanmaslow
Copy link
Collaborator

ivanmaslow commented Aug 15, 2024 •
edited
Loading

  • User can save only one reaction with Multi-Tailed arrow (simple reaction) to RXN, after loading from RXN it will be displayed as a simple reaction (plus and arrow) 
  • When user saves several reactions or cascade reactions with multi-tailed or single arrows only the first root reaction is saved
@ivanmaslow
Copy link
Collaborator Author

Discussed with @AlexanderSavelyev - it's blocked by #2235

@ivanmaslow ivanmaslow added Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes labels Aug 15, 2024
@yauhen-karmyzau yauhen-karmyzau added this to the Indigo-1.24.0-rc.1 milestone Aug 28, 2024
@yauhen-karmyzau
Copy link
Collaborator

Implemented in scope #2237

@ivanmaslow ivanmaslow mentioned this issue Oct 1, 2024
Open
@ivanmaslow ivanmaslow added the Test Cases Written Test cases has been written for that issue label Oct 3, 2024
This was referenced Oct 3, 2024
Open
Closed
Closed
@ivanmaslow
Copy link
Collaborator Author

ivanmaslow commented Oct 11, 2024 •
edited
Loading

Exploratory testing is completed on RC Remote environment:

  • Ketcher [Version 2.26.0-rc.1] Build at 2024-10-04; 18:45:04
  • Indigo Version 1.25.0-rc.1.0-g704673fcb-x86_64-linux-gnu-11.2.1
  • Desktop, Windows 11 Enterprise
  • Chrome Version 129.0.6668.100 (Official Build) (64-bit)

Points below are covered during testing, tests are updated:

  • If user added Multi-Tailed Arrow to Canvas, option of saving to RXN V2000/V3000 is available:
    image
  • If different types of reactions (single, cascade, combinations) are on Canvas, after saving to RXN V2000/V3000 the only one root reaction is saved, structure of the file is displayed on preview:
    image
  • Single reactions with Multi-Tailed arrow (1) can be saved to MDL Rxnfile V2000/MDL Rxnfile V3000/Daylight Smarts/Daylight SMILES/Extended SMILES, but after loading they will be displayed (2) with single arrows and pluses:
    image
  • Reactions with Multi-Tailed or single arrows can be loaded from ket, RDF or added by tools and after that saved to RXN V2000/V3000

During exploratory testing a huge part of tests fail because of opened defects, they will be fixed according to priority and selected milestones. Retesting is required after fixing because the core functionality is affected, also behavior can be affected by fixes for #2237:

@Zhirnoff Zhirnoff mentioned this issue Oct 28, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
Cascade reactions MMPK Scope for Pathway reactions, View-only mode, Static images, Custom buttons and Ketcher API changes Test Cases Written Test cases has been written for that issue
Projects
None yet
Milestone
Indigo-1.25.0-rc.1
Development

No branches or pull requests
3 participants
@even1024 @ivanmaslow @yauhen-karmyzau