Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Export to three letter amino acid codes cause convert error. #2660

Closed
AlexeyGirin opened this issue Nov 6, 2024 · 2 comments · Fixed by #2619, #2618, epam/ketcher#6014, epam/ketcher#6015 or #2663
Closed

Export to three letter amino acid codes cause convert error. #2660

AlexeyGirin opened this issue Nov 6, 2024 · 2 comments · Fixed by #2619, #2618, epam/ketcher#6014, epam/ketcher#6015 or #2663
Assignees
@even1024
Labels
Bug Export to Sequence Bucket: Bugs related to Export to Sequence mode Priority: High
Milestone
Indigo-1.26.0-rc.3

Comments

@AlexeyGirin
Copy link
Collaborator

AlexeyGirin commented Nov 6, 2024 •
edited
Loading

Issue below doesn't work on SA version, but works on remote as per @AliaksandrDziarkach

Steps to Reproduce

  1. Go to Macro - Flex mode
  2. Put any peptide on the canvas (A in my case)
  3. Save it to 3-letter sequence

Actual behavior
System throws an error: Convert error! Unsupported chemical mime type
image

Expected behavior
Export work correct (export result should be Ala)

As per requirement:

Three letter codes

Amino acid(s) name Amino acid single letter code Amino acid three letter code Note
Alanine A Ala

Versions

  • Ketcher Version 2.27.0-rc.1 Build at 2024-11-05; 14:55:18
  • Indigo Toolkit Version 1.26.0-rc.1.0-g904d2d992-wasm32-wasm-clang-19.0.0
  • Chrome Version 130.0.6723.117 (Official Build) (64-bit)
  • Win10

Found while testing - epam/ketcher#5556, #2472
@AlexeyGirin AlexeyGirin added Bug Priority: High Export to Sequence Bucket: Bugs related to Export to Sequence mode labels Nov 6, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/ketcher Nov 6, 2024
@AliaksandrDziarkach AliaksandrDziarkach changed the title Export to three letter amino acid codes sequence doesn't work - Convert error! Unsupported chemical mime type Export to three letter amino acid codes cause convert error. Nov 6, 2024
AliaksandrDziarkach referenced this issue Nov 6, 2024
@AliaksandrDziarkach
#2615 - Export to three letter amino acid codes cause convert error.
f65ca56 
Fix code. Add UTs
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Nov 6, 2024 that will close this issue
#2615 - Export to three letter amino acid codes cause convert error. #2618
Merged
8 tasks
@AlexeyGirin AlexeyGirin mentioned this issue Nov 6, 2024
Closed
@AliaksandrDziarkach AliaksandrDziarkach removed a link to a pull request Nov 6, 2024
#2615 - Export to three letter amino acid codes cause convert error. #2618
Merged
8 tasks
AliaksandrDziarkach referenced this issue Nov 6, 2024
@AliaksandrDziarkach
Backmerge: #2615 - Export to three letter amino acid codes cause conv…
681abe9 
…ert error.

backmerge to master
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Nov 6, 2024 that will close this issue
Backmerge: #2615 - Export to three letter amino acid codes cause convert error. #2619
Merged
4 tasks
AlexanderSavelyev referenced this issue Nov 7, 2024
@AliaksandrDziarkach
#2615 - Export to three letter amino acid codes cause convert error. (…
b87b6ca 
…#2618)

Co-authored-by: Aliakasndr Dziarkach <Aliakasndr.Dziarkach@gmail.com>
AlexanderSavelyev referenced this issue Nov 7, 2024
@AliaksandrDziarkach
Backmerge: #2615 - Export to three letter amino acid codes cause conv…
77b534f 
…ert error. (#2619)
@AlexeyGirin AlexeyGirin mentioned this issue Nov 7, 2024
Closed
@AliaksandrDziarkach AliaksandrDziarkach self-assigned this Nov 11, 2024
@AliaksandrDziarkach AliaksandrDziarkach linked a pull request Nov 11, 2024 that will close this issue
#2615 - Export to three letter amino acid codes cause convert error. #2618
Merged
8 tasks
AliaksandrDziarkach referenced this issue Nov 11, 2024
@AliaksandrDziarkach
#2615 Export to three letter amino acid codes cause convert error.
dc93153 
Fix typo
AliaksandrDziarkach referenced this issue Nov 11, 2024
@AliaksandrDziarkach
#2615 - Export to three letter amino acid codes cause convert error
0577014 
Fix typo
AliaksandrDziarkach referenced this issue Nov 11, 2024
@AliaksandrDziarkach
Backmerge: #2615 - Export to three letter amino acid codes cause conv…
2f2ee97 
…ert error

fix typo
AliaksandrDziarkach referenced this issue Nov 11, 2024
@AliaksandrDziarkach
#2615 - Export to three letter amino acid codes cause convert error (#…
f9c40ce 
…2625)
AliaksandrDziarkach referenced this issue Nov 11, 2024
@AliaksandrDziarkach
Backmerge: #2615 - Export to three letter amino acid codes cause conv…
f37b576 
…ert error (#2626)
@AlexeyGirin
Copy link
Collaborator Author

AlexeyGirin commented Nov 14, 2024 •
edited
Loading

Not fixed.
image

  • Ketcher Version 2.27.0-rc.2 Build at 2024-11-12; 19:26:10
  • Indigo Toolkit Version 1.26.0-rc.2.0-gfec30ecd8-wasm32-wasm-clang-19.0.0
  • Chrome Version 131.0.6778.70 (Official Build) (64-bit)
  • Win10

@AlexeyGirin AlexeyGirin reopened this Nov 14, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/Indigo Nov 14, 2024
@rrodionov91 rrodionov91 self-assigned this Nov 26, 2024
rrodionov91 referenced this issue in epam/ketcher Nov 26, 2024
@rrodionov91
#5972 - Export to three letter amino acid codes cause convert error
a883c93
rrodionov91 referenced this issue in epam/ketcher Nov 26, 2024
@rrodionov91
#5972 - Export to three letter amino acid codes cause convert error
4151794
@rrodionov91 rrodionov91 linked a pull request Nov 26, 2024 that will close this issue
#5972 - Export to three letter amino acid codes cause convert error epam/ketcher#6014
Merged
9 tasks
@rrodionov91 rrodionov91 linked a pull request Nov 26, 2024 that will close this issue
Backmerge: #5972 - Export to three letter amino acid codes cause convert error epam/ketcher#6015
Merged
9 tasks
rrodionov91 referenced this issue in epam/ketcher Nov 26, 2024
@rrodionov91
#5972 - Export to three letter amino acid codes cause convert error (#…
b8a338e 
…6014)
rrodionov91 referenced this issue in epam/ketcher Nov 26, 2024
@rrodionov91
#5972 - Export to three letter amino acid codes cause convert error (#…
e633d31 
…6015)
@AlexeyGirin AlexeyGirin reopened this Nov 27, 2024
@AlexeyGirin AlexeyGirin transferred this issue from epam/ketcher Nov 27, 2024
@AlexeyGirin
Copy link
Collaborator Author

Not fixed, reopened
image

@AlexeyGirin AlexeyGirin added this to the Indigo-1.26.0-rc.3 milestone Nov 27, 2024
@AlexeyGirin AlexeyGirin assigned even1024 and unassigned rrodionov91 Nov 27, 2024
@even1024 even1024 linked a pull request Nov 28, 2024 that will close this issue
Backmerge: #2660 - Export to three letter amino acid codes cause convert error #2663
Merged
7 tasks
even1024 added a commit that referenced this issue Nov 28, 2024
@even1024
#2660 - Export to three letter amino acid codes cause convert error (#…
690753b 
…2663)
even1024 added a commit that referenced this issue Dec 2, 2024
@even1024
#2660 - Export to three letter amino acid codes cause convert error (#…
f3357c5 
…2663)
AlexanderSavelyev pushed a commit that referenced this issue Dec 2, 2024
@even1024
#2660 - Export to three letter amino acid codes cause convert error (#…
3c899f9 
…2669)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@even1024 even1024

Labels
Bug Export to Sequence Bucket: Bugs related to Export to Sequence mode Priority: High
Projects
None yet
Milestone
Indigo-1.26.0-rc.3
4 participants
@even1024 @rrodionov91 @AliaksandrDziarkach @AlexeyGirin