Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #779: remove NonCopyable and shallow copy operations in Array<> #821

Draft
wants to merge 42 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from 9 commits
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
b0a254f
int[2] arrays removal
even1024 Aug 5, 2022
7a385c9
bool & char array separated
even1024 Aug 5, 2022
8fc764e
bool & char array separated
even1024 Aug 5, 2022
dfbdbd6
int array separated
even1024 Aug 5, 2022
7708663
memcmp
even1024 Aug 5, 2022
e633d84
pop eliminate
even1024 Aug 6, 2022
c6a5c75
working on push
even1024 Aug 7, 2022
fb98799
working on push
even1024 Aug 7, 2022
0e00453
working on push
even1024 Aug 7, 2022
3e6cbf2
working on push
even1024 Aug 7, 2022
6c8a63c
perfect forwarding
even1024 Aug 8, 2022
213367d
clang fix
even1024 Aug 8, 2022
11300fe
clang fix
even1024 Aug 8, 2022
14d2bef
destructor fix
even1024 Aug 8, 2022
d25066b
destructor fix
even1024 Aug 9, 2022
668b129
clang fix
even1024 Aug 9, 2022
85d900e
clang fix
even1024 Aug 9, 2022
285e088
working to eliminate push
even1024 Aug 9, 2022
a4d71d8
clang fix
even1024 Aug 9, 2022
c6f1e47
working to eliminate push.
even1024 Aug 9, 2022
250521f
working to eliminate push.
even1024 Aug 10, 2022
5112239
clang fix
even1024 Aug 10, 2022
45e3636
correct method names for containers
even1024 Aug 10, 2022
d223ac9
push elimination
even1024 Aug 10, 2022
84674e9
clang fix
even1024 Aug 10, 2022
64ebaf9
bingo fix
even1024 Aug 11, 2022
b1fccae
bingo fix
even1024 Aug 11, 2022
d33132d
constructors fix
even1024 Aug 12, 2022
b0995b5
clang fix
even1024 Aug 12, 2022
14ef685
clang fix
even1024 Aug 12, 2022
7b24408
copy and concat
even1024 Aug 17, 2022
c9fb4dc
push back
even1024 Aug 17, 2022
c0f5fe0
push back
even1024 Aug 17, 2022
ba50cc6
push back
even1024 Aug 17, 2022
be6ae99
push back
even1024 Aug 17, 2022
c8cc428
push back
even1024 Aug 17, 2022
2437e12
only resize
even1024 Aug 18, 2022
4127c18
double
even1024 Aug 18, 2022
53ee0d8
array.h
even1024 Aug 22, 2022
5571727
basic types
even1024 Aug 22, 2022
8a37651
basic types 1
even1024 Aug 22, 2022
dede3bd
basic types 1
even1024 Aug 22, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/c/bingo-nosql/src/bingo_multibit_tree.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@ void MultibitTree::_build()

QS_DEF(Array<bool>, is_mb);
is_mb.clear_resize(_fp_size * 8);
is_mb.zerofill();
is_mb.fill(false);

_tree_ptr = _buildNode(indices, is_mb, 0);
}
Expand Down
6 changes: 3 additions & 3 deletions api/c/indigo/src/indigo_molecule.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -3307,13 +3307,13 @@ CEXPORT int indigoSetSGroupBrackets(int sgroup, int brk_style, float x1, float y

psg->brk_style = brk_style;
psg->brackets.clear();
Vec2f* brackets = psg->brackets.push();
std::array<Vec2f, 2> brackets;
brackets[0].set(x1, y1);
brackets[1].set(x2, y2);
brackets = psg->brackets.push();
psg->brackets.emplace_back(brackets);
brackets[0].set(x3, y3);
brackets[1].set(x4, y4);

psg->brackets.emplace_back(brackets);
return 1;
}
INDIGO_END(-1);
Expand Down
2 changes: 1 addition & 1 deletion api/c/indigo/src/indigo_object.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@
#include "reaction/reaction.h"

using IndigoObjectTypesMap = std::map<int, const char* const>;
class IndigoObjectTypes : public IndigoObjectTypesMap, public NonCopyable
class IndigoObjectTypes : public IndigoObjectTypesMap
{
public:
IndigoObjectTypes();
Expand Down
Loading