Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix randomly failing composition/basic test due to an incorrect ordering of fragments #923

Conversation

loimu
Copy link
Collaborator

@loimu loimu commented Dec 7, 2022

Issue #521: core: replace MultiMap with standard library container
Replace std::multimap with std::map of vectors. Fixes randomly failing composition/basic test due to an incorrect ordering of fragments

@loimu loimu changed the title Fixes randomly failing composition/basic test due to an incorrect ordering of elements Fixes randomly failing composition/basic test due to an incorrect ordering of fragments Dec 7, 2022
@loimu loimu self-assigned this Dec 7, 2022
@loimu loimu changed the title Fixes randomly failing composition/basic test due to an incorrect ordering of fragments Fix randomly failing composition/basic test due to an incorrect ordering of fragments Dec 7, 2022
@loimu loimu force-pushed the feature/521_std_multimap_molecule_rgroups_composition_fix branch from e1c3293 to 9379bb7 Compare December 7, 2022 10:33
Replace std::multimap with std::map of vectors. Fixes randomly failing composition/basic test due to an incorrect ordering of fragments
@loimu loimu force-pushed the feature/521_std_multimap_molecule_rgroups_composition_fix branch from 9379bb7 to 71e469b Compare December 7, 2022 11:21
@loimu
Copy link
Collaborator Author

loimu commented Dec 7, 2022

The fix doesn't seem to be valid

@loimu loimu closed this Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant