Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(chat): refactor application dialogs, add deployable app dialog draft (Issue #2353) #2355

Merged
merged 54 commits into from
Oct 29, 2024
Merged

feat(chat): refactor application dialogs, add deployable app dialog draft (Issue #2353) #2355

merged 54 commits into from
Oct 29, 2024

Conversation

Gimir
Copy link
Contributor

@Gimir Gimir commented Oct 11, 2024 •
edited
Loading

Description:

  • refactor app dialogs
    • combine all application dialogs together
    • rework validation
    • extract smaller reusable components from forms
    • rework applications get/update types
    • update colors
  • add code app dialog
  • add start/stop application feature
  • add code-apps feature flag

Issues:

Checklist:

  • the pull request name complies with Conventional Commits
  • the pull request name starts with fix(<scope>):, feat(<scope>):, feature(<scope>):, chore(<scope>):, hotfix(<scope>): or e2e(<scope>):. If contains breaking changes then the pull request name must start with fix(<scope>)!:, feat(<scope>)!:, feature(<scope>)!:, chore(<scope>)!:, hotfix(<scope>)!: or e2e(<scope>)!: where <scope> is name of affected project: chat, chat-e2e, overlay, shared, sandbox-overlay, etc.
  • the pull request name ends with (Issue #<TICKET_ID>) (comma-separated list of issues)
  • I confirm that do not share any confidential information like API keys or any other secrets and private URLs

@Gimir Gimir added the enhancement New feature or request label Oct 11, 2024
@Gimir Gimir self-assigned this Oct 11, 2024
@Gimir
Copy link
Contributor Author

Gimir commented Oct 11, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Oct 11, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir
Copy link
Contributor Author

Gimir commented Oct 28, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

IlyaBondar
IlyaBondar previously approved these changes Oct 28, 2024
View reviewed changes
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Oct 28, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

@Gimir
Copy link
Contributor Author

Gimir commented Oct 28, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Oct 28, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: failed

1 similar comment
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Oct 29, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: failed

@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Oct 29, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: success

IlyaBondar
IlyaBondar previously approved these changes Oct 29, 2024
View reviewed changes
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Oct 29, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: failed

@Gimir Gimir enabled auto-merge (squash) October 29, 2024 11:56
@IlyaBondar
Copy link
Collaborator

IlyaBondar commented Oct 29, 2024 •
edited by ai-dial-actions
Loading

/deploy-review

Environment URL: https://chat-ai-dial-chat-pr-2355.nightly-test.deltixhub.io
E2E tests status: success

@Gimir Gimir disabled auto-merge October 29, 2024 12:31
@IlyaBondar IlyaBondar merged commit 3c96d79 into development Oct 29, 2024
9 checks passed
@IlyaBondar IlyaBondar deleted the feat/python-apps branch October 29, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexander-Kezik Alexander-Kezik Alexander-Kezik left review comments

@IlyaBondar IlyaBondar IlyaBondar approved these changes

@denys-kolomiitsev denys-kolomiitsev Awaiting requested review from denys-kolomiitsev denys-kolomiitsev is a code owner

@Derikyan Derikyan Awaiting requested review from Derikyan Derikyan is a code owner

@likeamike likeamike Awaiting requested review from likeamike likeamike is a code owner

Assignees

@Gimir Gimir

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gimir @IlyaBondar @Alexander-Kezik @Derikyan