Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Markdown is broken for the Tools Description page (and probably others) #2445

Open
sidoruka opened this issue Dec 28, 2021 · 2 comments
Open

Markdown is broken for the Tools Description page (and probably others) #2445

sidoruka opened this issue Dec 28, 2021 · 2 comments
Labels
kind/bug Something isn't working state/has-case Issues that have test-cases state/verify Issues that are already addressed and require validation sys/gui Issues related to the web gui
Milestone
v0.17

Comments

@sidoruka
Copy link
Contributor

sidoruka commented Dec 28, 2021 •
edited
Loading

Background
Looks like the GUI themes management feature has broke the Markdown rendering which we have in the Tools/Pipelines descriptions.

E.g. bulleted lists are not displayed well:

  • This markdown:
* One
* Two
* Three
  • Is shown as:
    image
  • While shall be like this:
    • One
    • Two
    • Three

Approach

  • Determine all the locations, where we have the Markdown rendering in the Cloud Pipeline GUI (i.e. Tools Description, Pipeline Description, Support page, etc.)
  • Go through the Basic MD formatting and check which features are not working well and fix that
    • Headings
    • Styling text
    • Quoting text
    • Quoting code
    • Links
    • Images
    • Lists
  • Make sure to verify the fixes in all of the default color themes (Light/Dark/Dimmed)
    dered.
@sidoruka sidoruka added kind/bug Something isn't working sys/gui Issues related to the web gui labels Dec 28, 2021
@sidoruka sidoruka added this to the v0.17 milestone Dec 28, 2021
rodichenko pushed a commit that referenced this issue Jan 10, 2022
@AlfiyaRF
Issue #2445: markdown styles (#2452)
41d5b25 
* fixes for markdown

* removed unnecessary styles
rodichenko added a commit that referenced this issue Jan 10, 2022
@rodichenko
Markdown is broken for the Tools Description page (and probably other…
752c827 
…s) (#2445) - markdown styles fixed
rodichenko pushed a commit that referenced this issue Jan 10, 2022
@AlfiyaRF @rodichenko
Markdown is broken for the Tools Description page (and probably other…
0724589 
…s) (#2445) - markdown styles fixed
@rodichenko rodichenko added the state/verify Issues that are already addressed and require validation label Jan 10, 2022
@maryvictol maryvictol mentioned this issue Mar 14, 2022
Merged
@maryvictol maryvictol mentioned this issue Jun 9, 2022
Closed
rodichenko pushed a commit that referenced this issue Jul 8, 2022
@AlfiyaRF @rodichenko
Markdown is broken for the Tools Description page (and probably other…
d560a7f 
…s) (#2445) - markdown styles fixed, backported to release/0.16
rodichenko pushed a commit that referenced this issue Jul 8, 2022
@AlfiyaRF @rodichenko
Markdown is broken for the Tools Description page (and probably other…
d050790 
…s) (#2445) - markdown styles fixed, backported to stage/0.16/20220314
@rodichenko
Copy link
Contributor

Backported to release/0.16 (d560a7f) and stage/0.16/20220314 (d050790)

@maryvictol
Copy link
Collaborator

Test case was created by #2554 and located here.

@maryvictol maryvictol added the state/has-case Issues that have test-cases label Oct 20, 2022
@maryvictol maryvictol mentioned this issue Apr 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working state/has-case Issues that have test-cases state/verify Issues that are already addressed and require validation sys/gui Issues related to the web gui
Projects
None yet
Milestone
v0.17
Development

No branches or pull requests
3 participants
@rodichenko @sidoruka @maryvictol