Issue #1636 Node pools for Azure and GCP #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ureInstanceService
mzueva
suggested changes
Dec 10, 2020
| @@ -68,14 +68,14 @@ def __init__(self, cloud_region, num_rep=10): | |||
| self.ec2 = boto3.client('ec2', config=Config(retries={'max_attempts': BOTO3_RETRY_COUNT})) | |||
|
|
|||
| def run_instance(self, is_spot, bid_price, ins_type, ins_hdd, ins_img, ins_key, run_id, kms_encyr_key_id, | |||
| num_rep, time_rep, kube_ip, kubeadm_token): | |||
| num_rep, time_rep, kube_ip, kubeadm_token, pre_pull_images=None): | |||
There was a problem hiding this comment.
Let's use empty list as default value: pre_pull_images =[]
mzueva
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #1636.
It brings support of node pool operations for Azure and GCP.