issue #3131 fix for run worker nodes #3163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SilinPavel
force-pushed
the
issue_3131_fix_for_worker_configuration
branch
2 times, most recently
from
6aa8146
to
25c4130
Compare
…each worker run
SilinPavel
force-pushed
the
issue_3131_fix_for_worker_configuration
branch
from
25c4130
to
e43ec02
Compare
mzueva
suggested changes
Mar 30, 2023
| configuration.setEraseRunEndpoints(hasBooleanParameter(configuration, ERASE_WORKER_ENDPOINTS)); | ||
| final Map<String, PipeConfValueVO> configParameters = MapUtils.isEmpty(configuration.getParameters()) ? | ||
| new HashMap<>() : configuration.getParameters(); | ||
| public PipelineConfiguration copyAsMasterConfiguration(final PipelineConfiguration configuration, |
There was a problem hiding this comment.
Maybe we should name the methods similar? generateMasterConfiguration and generateWorkerConfiguration
| final PipelineConfiguration runConfiguration; | ||
| if (!StringUtils.hasText(clusterId)) { | ||
| log.debug("Launching master entry {}", entry.getName()); | ||
| runConfiguration = pipelineConfigurationManager.copyAsMasterConfiguration(configuration, startNFS); |
There was a problem hiding this comment.
We can return results immediately instead of assigning the variable
…each worker run
sidoruka
pushed a commit
that referenced
this pull request
Mar 31, 2023
maryvictol
pushed a commit
that referenced
this pull request
Apr 5, 2023
ekazachkova
pushed a commit
that referenced
this pull request
Apr 5, 2023
AleksandrGorodetskii
pushed a commit
that referenced
this pull request
Apr 5, 2023
sidoruka
pushed a commit
that referenced
this pull request
Apr 5, 2023
mzueva
pushed a commit
that referenced
this pull request
Apr 20, 2023
mzueva
added a commit
that referenced
this pull request
Jan 8, 2024
mzueva
added a commit
that referenced
this pull request
Jan 8, 2024
mzueva
added a commit
that referenced
this pull request
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now we are copy
runConfigurationif we need it to be used as configuration for child runs.