Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #3131 fix for run worker nodes #3163

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

SilinPavel
Copy link
Member

@SilinPavel SilinPavel commented Mar 29, 2023

Now we are copy runConfiguration if we need it to be used as configuration for child runs.

@SilinPavel SilinPavel force-pushed the issue_3131_fix_for_worker_configuration branch 2 times, most recently from 6aa8146 to 25c4130 Compare March 30, 2023 12:08
@SilinPavel SilinPavel force-pushed the issue_3131_fix_for_worker_configuration branch from 25c4130 to e43ec02 Compare March 30, 2023 12:13
@SilinPavel SilinPavel marked this pull request as ready for review March 30, 2023 12:23
configuration.setEraseRunEndpoints(hasBooleanParameter(configuration, ERASE_WORKER_ENDPOINTS));
final Map<String, PipeConfValueVO> configParameters = MapUtils.isEmpty(configuration.getParameters()) ?
new HashMap<>() : configuration.getParameters();
public PipelineConfiguration copyAsMasterConfiguration(final PipelineConfiguration configuration,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should name the methods similar? generateMasterConfiguration and generateWorkerConfiguration

final PipelineConfiguration runConfiguration;
if (!StringUtils.hasText(clusterId)) {
log.debug("Launching master entry {}", entry.getName());
runConfiguration = pipelineConfigurationManager.copyAsMasterConfiguration(configuration, startNFS);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can return results immediately instead of assigning the variable

@mzueva mzueva merged commit 32eaebf into develop Mar 30, 2023
sidoruka pushed a commit that referenced this pull request Mar 31, 2023
* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

(cherry picked from commit 32eaebf)
maryvictol pushed a commit that referenced this pull request Apr 5, 2023
* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

(cherry picked from commit 32eaebf)
ekazachkova pushed a commit that referenced this pull request Apr 5, 2023
* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

(cherry picked from commit 32eaebf)
AleksandrGorodetskii pushed a commit that referenced this pull request Apr 5, 2023
* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

(cherry picked from commit 32eaebf)
sidoruka pushed a commit that referenced this pull request Apr 5, 2023
* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

(cherry picked from commit 32eaebf)
(cherry picked from commit 6ec6938)
mzueva pushed a commit that referenced this pull request Apr 20, 2023
* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

* issue #3131 fix for run worker nodes - cleanup run configuration for each worker run

(cherry picked from commit 32eaebf)
(cherry picked from commit 6ec6938)
mzueva added a commit that referenced this pull request Jan 8, 2024
mzueva added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants