Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve GPU details for AWS and GCP instance types #3341

Merged
merged 7 commits into from
Aug 24, 2023

Conversation

tcibinan
Copy link
Contributor

@tcibinan tcibinan commented Aug 21, 2023

Resolves issue #3337 for AWS and GCP.

The pull request adds an optional section gpuDevice to instance type structure which has optional fields name, manufacturer and cores.

{
    "gpu": 0
}
{
    "gpu": 2
}
{
    "gpu": 2,
    "gpuDevice": {
        "name": "A10G",
        "manufacturer": "NVIDIA",
        "cores": 9216
    }
}
{
    "gpu": 2,
    "gpuDevice": {
        "name": "A10G",
        "manufacturer": "NVIDIA"
    }
}
{
    "gpu": 2,
    "gpuDevice": {
        "name": "A10G"
    }
}

@tcibinan tcibinan requested a review from mzueva August 21, 2023 14:15
@tcibinan tcibinan merged commit fb193fe into develop Aug 24, 2023
4 checks passed
rodichenko pushed a commit that referenced this pull request Aug 28, 2023
Resolve GPU details for AWS and GCP instance types (#3341) - GUI
tcibinan added a commit that referenced this pull request Aug 30, 2023
* Add support for gpu type and cores to instance offers

* Implement support for AWS

* Implement support for GCP

* Store gpu name and manufacturer separately

* Introduce ec2 gpu helper interface

* Add instance price service tests

* Resolve pmd and checkstyle issues
rodichenko pushed a commit that referenced this pull request Aug 30, 2023
tcibinan added a commit that referenced this pull request Sep 1, 2023
* Add support for gpu type and cores to instance offers

* Implement support for AWS

* Implement support for GCP

* Store gpu name and manufacturer separately

* Introduce ec2 gpu helper interface

* Add instance price service tests

* Resolve pmd and checkstyle issues
rodichenko pushed a commit that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants