-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve GPU details for AWS and GCP instance types #3341
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mzueva
approved these changes
Aug 22, 2023
rodichenko
added a commit
that referenced
this pull request
Aug 28, 2023
rodichenko
added a commit
that referenced
this pull request
Aug 28, 2023
rodichenko
pushed a commit
that referenced
this pull request
Aug 28, 2023
Resolve GPU details for AWS and GCP instance types (#3341) - GUI
tcibinan
added a commit
that referenced
this pull request
Aug 30, 2023
* Add support for gpu type and cores to instance offers * Implement support for AWS * Implement support for GCP * Store gpu name and manufacturer separately * Introduce ec2 gpu helper interface * Add instance price service tests * Resolve pmd and checkstyle issues
rodichenko
pushed a commit
that referenced
this pull request
Aug 30, 2023
…kported to stage/0.16/uat
tcibinan
added a commit
that referenced
this pull request
Sep 1, 2023
* Add support for gpu type and cores to instance offers * Implement support for AWS * Implement support for GCP * Store gpu name and manufacturer separately * Introduce ec2 gpu helper interface * Add instance price service tests * Resolve pmd and checkstyle issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #3337 for AWS and GCP.
The pull request adds an optional section
gpuDevice
to instance type structure which has optional fieldsname
,manufacturer
andcores
.