Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #3345. Synchronize umask for cp_dav service and permissions that we are granting during file and folder creation on API #3346

Merged

Conversation

SilinPavel
Copy link
Member

@SilinPavel SilinPavel commented Aug 23, 2023

Related to #3345

  • Introducing CP_FILE_SHARE_STORAGE_DEFAULT_UMASK env to use it in cp-dav and cp-api-srv

Taking in consideration that in Linux the default maks for files is 666 and folders 777, logic in the cp-api-srv as follow:

  • get umask from CP_FILE_SHARE_STORAGE_DEFAULT_UMASK
  • calculate allowed permissions from that umask
  • filter these permission with regards to default linux masks for files and folders

@SilinPavel SilinPavel force-pushed the issue_3345_sync_umask_for_webdav_and_api_storage_operations branch from b4f0abe to d53237d Compare August 23, 2023 15:32
…t we are granting during file and folder creation on API
@SilinPavel SilinPavel force-pushed the issue_3345_sync_umask_for_webdav_and_api_storage_operations branch from d53237d to 2e904f9 Compare August 23, 2023 15:35
@SilinPavel SilinPavel requested a review from mzueva August 23, 2023 16:28
@mzueva mzueva merged commit 1a5b769 into develop Aug 24, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants