Manage price list refresh transactions more efficiently #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcibinan
added a commit
that referenced
this pull request
Sep 5, 2023
* Manage price list refresh transactions more efficiently * Extract aws ec2 pricing url template system preference * Add more logging to aws price list readers
tcibinan
added a commit
that referenced
this pull request
Sep 5, 2023
* Manage price list refresh transactions more efficiently * Extract aws ec2 pricing url template system preference * Add more logging to aws price list readers
ekazachkova
reviewed
Sep 6, 2023
| LOGGER.debug("Inserted {} instance offers to {} {} region #{}.", | ||
| final List<InstanceOffer> offers = cloudFacade.refreshPriceListForRegion(region.getId()); | ||
| LOGGER.debug("Retrieved {} instance offers for regin {} {} #{}.", | ||
| offers.size(), region.getProvider(), region.getRegionCode(), region.getId()); |
| @@ -74,6 +74,12 @@ public void removeInstanceOffersForRegion(Long regionId) { | |||
| getJdbcTemplate().update(removeInstanceOffersForRegionQuery, regionId); | |||
| } | |||
|
|
|||
| @Transactional | |||
| public void replaceInstanceOffersForRegion(Long id, List<InstanceOffer> offers) { | |||
There was a problem hiding this comment.
Could you make args final?
ekazachkova
approved these changes
Sep 6, 2023
tcibinan
added a commit
that referenced
this pull request
Sep 6, 2023
Fixes changes introduced in #3358.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates #1019.
The pull request adds more efficient transaction management to region price list refresh operations.
Additionally, the pull request brings the following system preference:
cluster.aws.ec2.pricing.url.templatespecifies aws ec2 pricing url template. Defaults to https://pricing.us-east-1.amazonaws.com/offers/v1.0/aws/AmazonEC2/current/%s/index.csv.