Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manage price list refresh transactions more efficiently #3358

Merged

Conversation

tcibinan
Copy link
Contributor

@tcibinan tcibinan commented Sep 5, 2023

Relates #1019.

The pull request adds more efficient transaction management to region price list refresh operations.

Additionally, the pull request brings the following system preference:

tcibinan added a commit that referenced this pull request Sep 5, 2023
* Manage price list refresh transactions more efficiently

* Extract aws ec2 pricing url template system preference

* Add more logging to aws price list readers
tcibinan added a commit that referenced this pull request Sep 5, 2023
* Manage price list refresh transactions more efficiently

* Extract aws ec2 pricing url template system preference

* Add more logging to aws price list readers
@tcibinan tcibinan marked this pull request as ready for review September 5, 2023 15:20
LOGGER.debug("Inserted {} instance offers to {} {} region #{}.",
final List<InstanceOffer> offers = cloudFacade.refreshPriceListForRegion(region.getId());
LOGGER.debug("Retrieved {} instance offers for regin {} {} #{}.",
offers.size(), region.getProvider(), region.getRegionCode(), region.getId());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: regin -> region

@@ -74,6 +74,12 @@ public void removeInstanceOffersForRegion(Long regionId) {
getJdbcTemplate().update(removeInstanceOffersForRegionQuery, regionId);
}

@Transactional
public void replaceInstanceOffersForRegion(Long id, List<InstanceOffer> offers) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you make args final?

tcibinan added a commit that referenced this pull request Sep 6, 2023
Fixes changes introduced in #3358.
@tcibinan tcibinan merged commit 46b629a into develop Sep 7, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants