Fixed incorrect message formatting for env extension issue [#87]: #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NellyHargeliya
commented
Aug 11, 2023
NellyHargeliya
commented
- remove information about ENV from messages, left message about parameter and parameter component
- add test for a case with parameters without the component
- remove information about ENV from messages, left message about parameter and parameter component - add test for a case with parameters without the component
akranga
requested changes
Aug 16, 2023
There was a problem hiding this comment.
Better naming could be * Setting parameter ingress.hosts (component: test1)
Currently * Setting parameter ingress.hosts test1 is a confusing. Feel free to move component to the new line if you feel the single line maybe too long
* Setting parameter ingress.hosts
component: test1
| @@ -46,12 +48,12 @@ setup() { | |||
| @test "ask env: should print messages if parameters need to set for different component discriminators" { | |||
| run ask env "ARGO_HOST" -m "parameter ingress.hosts test1" +empty -d "$DOTENV_FILE" -ask-env --non-interactive | |||
| assert_success | |||
| assert_output --partial "* Setting parameter ingress.hosts test1, ARGO" | |||
| assert_output --partial "* Setting parameter ingress.hosts test1" | |||
There was a problem hiding this comment.
@NellyHargeliya please rename implementation to better naming * Setting parameter ingress.hosts (component: test1)`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.