Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent HUB_STACK_NAME parameter support #44

Closed
oginskis opened this issue May 22, 2023 · 4 comments
Closed

Consistent HUB_STACK_NAME parameter support #44

oginskis opened this issue May 22, 2023 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@oginskis
Copy link
Contributor

The HUB_STACK_NAME parameter is a de-facto human-readable stack identifier generated when a new stack gets initialized with the hubctl stack init extension. It should appear in the state even if a user does not explicitly add it as a stack parameter, otherwise, it causes several technical issues (for example, it's not possible to recover the stack from its remote state).

During the hubctl verb command, the HUB_STACK_NAME should be handled as follows:

  • if the hub state already exists, try to find hub.stackName in the stack parameters
  • if found: use the existing value
  • if not found OR existing hub state is not provided: use the value from the HUB_STACK_NAME environment variable AND add it to the state as hub.stackName
  • if the HUB_STACK_NAME environment variable is not set: generate a new value using petname library AND add it to the state as hub.stackName
@akranga
Copy link
Contributor

akranga commented Jun 8, 2023

@oginskis any progress?

@oginskis
Copy link
Contributor Author

This is done and released. Moved to done.

@oginskis
Copy link
Contributor Author

Sorry, not yet released, will go to 1.0.14

@oginskis
Copy link
Contributor Author

Released in v1.0.14

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants