Use sprig instead of custom go template functions #21 #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TheRealSpaceShip
commented
Apr 4, 2024
TheRealSpaceShip
commented
- Remove all except formatSubdomain and unquote
- Improve curly template encodings like base64, first, etc.
- Improve utils Keys and SortedKeys
7 tasks
arkadijs
force-pushed
the
21-better-range-support-for-go-template
branch
from
e46000f
to
1078ec1
Compare
- Remove all except formatSubdomain and unquote - Improve curly template encodings like base64, first, etc. - Improve utils Keys and SortedKeys
TheRealSpaceShip
force-pushed
the
21-better-range-support-for-go-template
branch
from
1078ec1
to
9609cc9
Compare
arkadijs
reviewed
Nov 11, 2024
| return url.Scheme, nil | ||
| } | ||
|
|
||
| var encodingsMap = map[string]func(interface{}) (interface{}, error){ |
There was a problem hiding this comment.
Looks like variable name doesn't match intention anymore. Now the variable contains parseURL which is not an encoding by any stretch. Also the corresponding message at call site.
Suggest converter or just function.
| } else if arg1.Kind() == reflect.String { | ||
| size, _ = strconv.Atoi(arg1.String()) | ||
| } else { | ||
| return "", fmt.Errorf("Argument type %T not yet supported", args[1]) |
There was a problem hiding this comment.
"argument for consistency.
| // Third optional argument is a delimiter (default is '-') | ||
| func formatSubdomain(args ...interface{}) (string, error) { | ||
| if len(args) == 0 { | ||
| return "", fmt.Errorf("hostname expects at least one argument") |
There was a problem hiding this comment.
May as well use errors.New().
| @@ -369,27 +371,22 @@ func Index(list []string, search string) int { | |||
| return index | |||
| } | |||
|
|
|||
| func SortedKeys(m map[string]string) []string { | |||
| func Keys[K cmp.Ordered, V any](m map[K]V) []K { | |||
There was a problem hiding this comment.
Constrained on Ordered but not used to sort the result?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.