Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ketcher-react not working out of the box with create-react-app #1241

Closed
karen-sarkisyan opened this issue Feb 7, 2022 · 0 comments · Fixed by #1278
Closed

ketcher-react not working out of the box with create-react-app #1241

karen-sarkisyan opened this issue Feb 7, 2022 · 0 comments · Fixed by #1278
Assignees
@neiloxx @akolyakov42
Labels
bug
Milestone
Release 2.5.0

Comments

@karen-sarkisyan
Copy link
Contributor

Steps to Reproduce

  1. Use create-react-app to create a React app
  2. Use ketcher-react to render an Editor component
  3. Build application

Expected behavior
A React Application with Ketcher is built

Actual behavior
Error is thrown, stating that 'url' package can't be resolved with newer Webpack. A manual resolution is suggested (which can be done only if CRA is ejected).

Screenshots
Pasted Graphic

Environment

  • macOS Monterrey
  • create-react-app@latest
  • ketcher-react@2.4.1
@karen-sarkisyan karen-sarkisyan changed the title Not working out of the box with create-react-app ketcher-react not working out of the box with create-react-app Feb 7, 2022
@AndreiMazol AndreiMazol assigned neiloxx and unassigned AndreiMazol Feb 11, 2022
@AndreiMazol AndreiMazol added this to the Release 2.5.0 milestone Feb 11, 2022
neiloxx added a commit that referenced this issue Feb 21, 2022
@neiloxx
Merge branch 'master' of github.com:epam/ketcher into #1241-ketcher-r…
f8e2ddd 
…eact-not-working-out-of-the-box-with-create-react-app
@neiloxx neiloxx linked a pull request Feb 21, 2022 that will close this issue
#1241 Ketcher react not working out of the box with create react app #1278
Merged
AndreiMazol pushed a commit that referenced this issue Feb 21, 2022
@neiloxx
#1241 Ketcher react not working out of the box with create react app (#…
3dedee6 
…1278)

* Replace jsonschema package with ajv in ketcher-core

* Replace jsonschema package with ajv in ketcher-react

* Rename variable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@neiloxx neiloxx

@akolyakov42 akolyakov42

Labels
bug
Projects
None yet
Milestone
Release 2.5.0
Development

Successfully merging a pull request may close this issue.

#1241 Ketcher react not working out of the box with create react app epam/ketcher
4 participants
@karen-sarkisyan @AndreiMazol @neiloxx @akolyakov42