Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong sign for specific types while ket-generation #1600

Closed
even1024 opened this issue May 13, 2022 · 3 comments · Fixed by #1606 or #1626
Closed

Wrong sign for specific types while ket-generation #1600

even1024 opened this issue May 13, 2022 · 3 comments · Fixed by #1606 or #1626
Assignees
@AnaMoskvina @ZhannaNovikova
Labels
bug
Milestone
Release 2.5.0

Comments

@even1024
Copy link
Collaborator

Steps to Reproduce

  1. Draw any reaction
  2. Draw a simple object
  3. Generate ket

Expected behavior

y coordinates for simple objects, pluses and arrows are negative as atom's y-coordinates inside molecules.

Actual behavior

y coordinates for simple objects, pluses and arrows are positive.
@even1024 even1024 added the bug label May 13, 2022
@AndreiMazol AndreiMazol added this to the Release 2.5.0 milestone May 13, 2022
@AnaMoskvina AnaMoskvina linked a pull request May 16, 2022 that will close this issue
#1600 wrong sign for specific types while ket generation #1606
Merged
AndreiMazol pushed a commit that referenced this issue May 16, 2022
@AnaMoskvina
#1600 wrong sign for specific types while ket generation (#1606)
9c4aa6b 
* fix wrong sign for rxn, text, simple objects

* update indigo-ketcher version

Co-authored-by: Anastasiia Moskvina <anastasiia_moskvina@epam.com>
@ZhannaNovikova
Copy link

Verified as fixed on Release 2.5.0.

@AnaMoskvina AnaMoskvina linked a pull request May 19, 2022 that will close this issue
#1600-wrong-sign-in-ket #1626
Merged
@AnaMoskvina
Copy link
Contributor

also fixed:

  • atom list/not list sign (Y position)
  • r-label sign (Y position)

@ZhannaNovikova
Copy link

Additional issues (atom list/not list sign (Y position) r-label sign (Y position) has been verified as fixed on Release 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaMoskvina AnaMoskvina

@ZhannaNovikova ZhannaNovikova

Labels
bug
Projects
None yet
Milestone
Release 2.5.0
4 participants
@even1024 @AndreiMazol @AnaMoskvina @ZhannaNovikova