Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elements should be hidden when the attribute hiddenControls is used #1601

Closed
ZhannaNovikova opened this issue May 13, 2022 · 2 comments · Fixed by #1618 or #1632
Closed

Elements should be hidden when the attribute hiddenControls is used #1601

ZhannaNovikova opened this issue May 13, 2022 · 2 comments · Fixed by #1618 or #1632
Assignees
@AnaMoskvina @ZhannaNovikova
Labels
bug
Milestone
Release 2.5.0

Comments

@ZhannaNovikova
Copy link

ZhannaNovikova commented May 13, 2022 •
edited
Loading

Steps to Reproduce:

  1. Insert clear to the query (http://localhost:4001/?hiddenControls=clear)
  2. Click Enter

Expected behavior:
The element is hidden

Actual behavior:
The following elements are not hidden:

Top Toolbar
clear
open
save
undo
redo
cut
copies
copy
copy-mol
copy-ket
copy-image
paste
zoom-in
zoom-out
zoom-list
arom
check

OS: [Windows NT 10.0 Win64; x64]
Browsers: Google Chrome: Version 100.0.4896.88/FireFox: Version 99.0.1 (64-bit)
Microsoft Edge: Version 101.0.1210.39 (Official build) (64-bit)

Ketcher v2.4.2-355-ga4fe0f21
@AndreiMazol AndreiMazol added this to the Release 2.5.0 milestone May 13, 2022
@AnaMoskvina AnaMoskvina linked a pull request May 18, 2022 that will close this issue
#1601 elements should be hidden when the attribute hiddenControls is used #1618
Merged
AndreiMazol pushed a commit that referenced this issue May 19, 2022
@AnaMoskvina
#1601 elements should be hidden when the attribute hiddenControls is …
06f33af 
…used (#1618)

* fix hiding buttons in top toolbar

* refactor last changes

Co-authored-by: Anastasiia Moskvina <anastasiia_moskvina@epam.com>
@ZhannaNovikova
Copy link
Author

The issue part is still reproducing. The zoom-list element is not hiding

@AnaMoskvina AnaMoskvina linked a pull request May 20, 2022 that will close this issue
#1601 hiddenControl fix #1632
Merged
AndreiMazol pushed a commit that referenced this issue May 23, 2022
@AnaMoskvina
#1601 hiddenControl fix (#1632)
4c2fa2b 
* add key prop

* revert change

* fix hiding zoom-list

Co-authored-by: Anastasiia Moskvina <anastasiia_moskvina@epam.com>
@ZhannaNovikova
Copy link
Author

Verified as fixed on Release 2.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnaMoskvina AnaMoskvina

@ZhannaNovikova ZhannaNovikova

Labels
bug
Projects
None yet
Milestone
Release 2.5.0
3 participants
@AndreiMazol @AnaMoskvina @ZhannaNovikova