Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add cdx support #1640

Closed
AndreiMazol opened this issue May 23, 2022 Discussed in #1605 · 3 comments · Fixed by #1650
Closed

add cdx support #1640

AndreiMazol opened this issue May 23, 2022 Discussed in #1605 · 3 comments · Fixed by #1650
Assignees
@Nitvex
Labels
external Issue depends on external services such as Indigo service feature request
Milestone
Release 2.7.0

Comments

@AndreiMazol
Copy link
Contributor

AndreiMazol commented May 23, 2022 •
edited
Loading

Discussed in #1605

Originally posted by CLLPCH May 13, 2022
Dear Ketcher team,

Thanks for the excellent Ketcher editor 👍
I found this #920 so the cdxml file format is supported. Then, I would like to know, do you have a plan to support cdx file format?

cdx files can be found here: https://github.com/epam/Indigo/tree/master/api/tests/integration/tests/formats/molecules
@AndreiMazol AndreiMazol self-assigned this May 23, 2022
@AndreiMazol AndreiMazol removed their assignment May 24, 2022
@AndreiMazol AndreiMazol added this to the Release 2.5.1 milestone May 24, 2022
@ZaimBeshich1 ZaimBeshich1 linked a pull request May 30, 2022 that will close this issue
#1640 add cdx support #1650
Merged
ZaimBeshich1 added a commit that referenced this issue Jun 14, 2022
@ZaimBeshich1
Merge branch 'master' into #1640-add-cdx-support
1176988
@AndreiMazol
Copy link
Contributor Author

Moved to 2.5.2: waiting for BE part.

ZaimBeshich1 added a commit that referenced this issue Jun 20, 2022
@ZaimBeshich1
Merge remote-tracking branch 'origin/master' into #1640-add-cdx-support
e529372
@Nitvex Nitvex added the external Issue depends on external services such as Indigo service label Nov 11, 2022
@Nitvex
Copy link
Collaborator

Nitvex commented Nov 11, 2022

Related indigo issue:
epam/Indigo#885

@Nitvex Nitvex modified the milestones: Release 3.0.0, Release 2.7.0 Nov 11, 2022
@vanoprenko
Copy link
Collaborator

Please implement not displaying file content while opening CDX file in scope of this task.

@Nitvex Nitvex modified the milestones: Release 2.7.0, Release 2.8.0 Nov 24, 2022
@vanoprenko vanoprenko removed this from the Release 2.8.0 milestone Dec 15, 2022
@vanoprenko vanoprenko added this to the Release 2.7.0 milestone Dec 15, 2022
Nitvex added a commit that referenced this issue Dec 15, 2022
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1640-a…
f6c75b3 
…dd-cdx-support
@Nitvex Nitvex assigned Nitvex and unassigned evgeniiFrolov1 Dec 16, 2022
Nitvex added a commit that referenced this issue Dec 16, 2022
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1640-a…
21a4e88 
…dd-cdx-support
Nitvex added a commit that referenced this issue Dec 16, 2022
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1640-a…
47a0dfa 
…dd-cdx-support
Nitvex added a commit that referenced this issue Dec 16, 2022
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1640-a…
1e34fd9 
…dd-cdx-support
Nitvex added a commit that referenced this issue Dec 16, 2022
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1640-a…
94bb224 
…dd-cdx-support
Nitvex added a commit that referenced this issue Dec 16, 2022
@ZaimBeshich1 @Nitvex
#1640 add cdx support (#1650)
10ce268 
* add cdx format to types

* add check for cdx format

* add magic word for cdx for recognizing on server

* delete magik number

* fix format check

* update indigo to 1.7.3

* fix format check

* clear string from unnecessary info

* clear string from \n symbols from clipboard

* update indigo version

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Nitvex added a commit that referenced this issue Dec 16, 2022
@ZaimBeshich1 @Nitvex
Backmerge: #1640 add cdx support (#1650)
c1d50c6 
* add cdx format to types

* add check for cdx format

* add magic word for cdx for recognizing on server

* delete magik number

* fix format check

* update indigo to 1.7.3

* fix format check

* clear string from unnecessary info

* clear string from \n symbols from clipboard

* update indigo version

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Nitvex added a commit that referenced this issue Dec 16, 2022
@Nitvex @ZaimBeshich1
Backmerge: #1640 add cdx support (#1650) (#1944)
fc6113a 
* add cdx format to types

* add check for cdx format

* add magic word for cdx for recognizing on server

* delete magik number

* fix format check

* update indigo to 1.7.3

* fix format check

* clear string from unnecessary info

* clear string from \n symbols from clipboard

* update indigo version

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>

Co-authored-by: ZaimBeshich1 <102960050+ZaimBeshich1@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
external Issue depends on external services such as Indigo service feature request
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1640 add cdx support epam/ketcher
6 participants
@vanoprenko @Nitvex @AndreiMazol @evgeniiFrolov1 @KonstantinEpam23 @ZaimBeshich1