Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create Salts and Solvents tab and include basic structures #1820

Closed
AlexanderSavelyev opened this issue Nov 9, 2022 · 0 comments · Fixed by #1891
Closed

Create Salts and Solvents tab and include basic structures #1820

AlexanderSavelyev opened this issue Nov 9, 2022 · 0 comments · Fixed by #1891
Assignees
@Nitvex
Labels
feature request
Milestone
Release 2.7.0

Comments

@AlexanderSavelyev
Copy link
Contributor

AlexanderSavelyev commented Nov 9, 2022 •
edited
Loading

Is your feature request related to a problem? Please describe.
Right now in templates there are no solvents and salts exist.

Describe the solution you'd like
Add "Salts and Solvents" tab into the templates tab and include structures copied below. The behavior should be the same as for functional groups (add super atoms)

salts_and_solvents.zip

In the list Ketcher should show abbreviations (field abbreviation in sdf), but when mouse-over Ketcher should show structure names (field name in sdf)

Button "Add to Canvas" and "Save to SDF" should be removed from "Salts and Solvents" tab
@AlexanderSavelyev AlexanderSavelyev added this to the Release 2.7.0 milestone Nov 9, 2022
@AlexanderSavelyev AlexanderSavelyev changed the title Create Solvents tab and include basic solvents Create Salts and Solvents tab and include basic structures Nov 16, 2022
@AlexanderSavelyev AlexanderSavelyev mentioned this issue Nov 16, 2022
Closed
@Nitvex Nitvex modified the milestones: Release 2.7.0, Release 2.8.0 Nov 24, 2022
@Nitvex Nitvex modified the milestones: Release 2.8.0, Release 2.7.0 Nov 30, 2022
Nitvex added a commit that referenced this issue Dec 5, 2022
@Nitvex
#1820 – adding salts and solvents tab
a236295
Nitvex added a commit that referenced this issue Dec 5, 2022
@Nitvex
#1820 added possibility to add Salts And Solvents to canvas
f8fce33
Nitvex added a commit that referenced this issue Dec 5, 2022
@Nitvex
#1820 – added salts and solvents merge prevention. Removed buttons fr…
14b056e 
…om footer
Nitvex added a commit that referenced this issue Dec 5, 2022
@Nitvex
#1820 – changed display of title and name for salts and solvents
e168b62
Nitvex added a commit that referenced this issue Dec 5, 2022
@Nitvex
#1820 – removed modifiedStruct from templates
f9a4b36
Nitvex added a commit that referenced this issue Dec 6, 2022
@Nitvex
#1820 – removed modifiedStruct from templates
2e6207e
Nitvex added a commit that referenced this issue Dec 6, 2022
@Nitvex
#1820 – UI improvements
92557fa
Nitvex added a commit that referenced this issue Dec 6, 2022
@Nitvex
#1820 – UI improvements
1965b5e
Nitvex added a commit that referenced this issue Dec 6, 2022
@Nitvex
#1820 – UI improvements
0ef8d50
Nitvex added a commit that referenced this issue Dec 6, 2022
@Nitvex
#1820 – UI improvements
f834320
Nitvex added a commit that referenced this issue Dec 6, 2022
@Nitvex
#1820 – UI improvements
448a616
@Nitvex Nitvex linked a pull request Dec 7, 2022 that will close this issue
#1820 add salts and solvents tab #1891
Merged
Nitvex added a commit that referenced this issue Dec 7, 2022
@Nitvex
#1820 – fixed dragging structure on salt or solvent
397d99e
Nitvex added a commit that referenced this issue Dec 8, 2022
@Nitvex
#1820 – fixed dragging structure on salt or solvent
d9c9f70
Nitvex added a commit that referenced this issue Dec 8, 2022
@Nitvex
Merge branch 'master' of https://github.com/epam/ketcher into #1820-a…
adb6b9f 
…dd-salts-and-solvents-tab
Nitvex added a commit that referenced this issue Dec 8, 2022
@Nitvex
#1820 add salts and solvents tab (#1891)
1f48399 
* #1820 – adding salts and solvents tab

* #1820 added possibility to add Salts And Solvents to canvas

* #1820 – added salts and solvents merge prevention. Removed buttons from footer

* #1820 – changed display of title and name for salts and solvents

* #1820 – removed modifiedStruct from templates

* #1820 – UI improvements

* #1820 – fixed dragging structure on salt or solvent
@Nitvex Nitvex added the rc.1 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
feature request
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1820 add salts and solvents tab epam/ketcher
3 participants
@AlexanderSavelyev @Nitvex @evgeniiFrolov1