Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Rotate Tool] Button actions are mixed up: Horizontal Flip button makes Vertical Flip and Vertical Flip button makes Horizontal Flip #1845

Closed
Zhirnoff opened this issue Nov 16, 2022 · 0 comments · Fixed by #1858
Closed

[Rotate Tool] Button actions are mixed up: Horizontal Flip button makes Vertical Flip and Vertical Flip button makes Horizontal Flip #1845

Zhirnoff opened this issue Nov 16, 2022 · 0 comments · Fixed by #1858
Assignees
@yuleicul @Nitvex
Labels
bug
Milestone
Release 2.7.0

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Create any structure
  3. Press 'Rotate Tool' button on left side or press Alt-R
  4. Click on 'Horizontal Flip' button and 'Vertical Flip' button
  5. Check results on structure

Actual behavior
Button actions are mixed up: Horizontal Flip button makes Vertical Flip and Vertical Flip button makes Horizontal Flip

Expected behavior
Button actions not mixed up: Horizontal Flip button makes Horizontal Flip and Vertical Flip button makes Vertical Flip

Screenshots
2022-11-16_16h46_45
2022-11-16_16h47_05

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 107.0.5304.107 (Official Build) (64-bit)

Ketcher version
[Version 2.6.1]
Build at 2022-11-10

Additional context
Add any other context about the problem here.
@Zhirnoff Zhirnoff added the bug label Nov 16, 2022
@Zhirnoff Zhirnoff added this to the Release 2.7.0 milestone Nov 16, 2022
yuleicul added a commit that referenced this issue Nov 18, 2022
@yuleicul
Fix flip tools being mixed up
988db23 
The icons of horizontal flip and vertical flip should be swapped.

* Swap flip icons
* Fix typo in 'transform'

Resolves #1845
@yuleicul yuleicul linked a pull request Nov 18, 2022 that will close this issue
Fix flip tools being mixed up #1858
Merged
@yuleicul yuleicul mentioned this issue Nov 18, 2022
Merged
yuleicul added a commit that referenced this issue Nov 19, 2022
@yuleicul
Fix flip tools being mixed up
6798f51 
The icons of horizontal flip and vertical flip should be swapped.

* Swap flip icons
* Fix typo in 'transform'

Resolves #1845
Nitvex added a commit that referenced this issue Nov 25, 2022
@Nitvex
#1845 – added more functional groups
fb279d8
Nitvex added a commit that referenced this issue Nov 29, 2022
@Nitvex
#1811 added more functional groups (#1868)
4bc788f 
* #1839 – removed lightweight tag from page title

* #1845 – added more functional groups

* #1811 – updated Boc and Mes functional groups

* #1811 – removed X in all functional groups
Nitvex added a commit that referenced this issue Dec 7, 2022
@Nitvex
#1811 added more functional groups (#1868)
34d807a 
* #1839 – removed lightweight tag from page title

* #1845 – added more functional groups

* #1811 – updated Boc and Mes functional groups

* #1811 – removed X in all functional groups
@Nitvex Nitvex added the rc.1 label Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

@Nitvex Nitvex

Labels
bug
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

Fix flip tools being mixed up epam/ketcher
3 participants
@yuleicul @Nitvex @Zhirnoff