Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Salts and Solvents tab: Abbreviation is expanded after adding to the canvas #1920

Closed
Zhirnoff opened this issue Dec 13, 2022 · 0 comments · Fixed by #1927
Closed

Salts and Solvents tab: Abbreviation is expanded after adding to the canvas #1920

Zhirnoff opened this issue Dec 13, 2022 · 0 comments · Fixed by #1927
Assignees
@Nitvex
Labels
bug
Milestone
Release 2.7.0

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Launch Ketcher
  2. Press 'Custom Templates' button and click on 'Salts and Solvents' tab
  3. Select for example 'DMF' and add to canvas
  4. Look at abbreviation

Actual behavior
Abbreviation is expanded after adding to the canvas

Expected behavior
Abbreviation is NOT expanded.

Screenshots

2022-12-13_18h39_58

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 108.0.5359.99 (Official Build) (64-bit)

Ketcher version
[v2.7.0]
@Zhirnoff Zhirnoff added this to the Release 2.7.0 milestone Dec 13, 2022
@Nitvex Nitvex assigned Nitvex and unassigned KonstantinEpam23 Dec 14, 2022
@KonstantinEpam23 KonstantinEpam23 mentioned this issue Dec 14, 2022
Merged
Nitvex added a commit that referenced this issue Dec 14, 2022
@Nitvex
#1920 – added abbreviation to Struct, fixed isSaltOrSolvent check
828bf14
KonstantinEpam23 added a commit that referenced this issue Dec 15, 2022
@KonstantinEpam23
Merge branch 'master' into #1920-abbreviation-is-expanded-after-addin…
e310dcf 
…g-to-the-canvas
KonstantinEpam23 added a commit that referenced this issue Dec 15, 2022
@KonstantinEpam23
Merge branch '#1920-abbreviation-is-expanded-after-adding-to-the-canv…
d2200e9 
…as' into #1921-incorrect-info-panel-behavior
@Nitvex Nitvex linked a pull request Dec 15, 2022 that will close this issue
#1920 Salts and Solvents tab: Abbreviation is expanded after adding to the canvas #1927
Merged
Nitvex added a commit that referenced this issue Dec 15, 2022
@Nitvex
#1920 – added abbreviation to Struct, fixed isSaltOrSolvent check (#1927
9c82981 
)
KonstantinEpam23 added a commit that referenced this issue Dec 15, 2022
@KonstantinEpam23 @Nitvex
#1921: Hovering over some functional groups crops the expanded view o…
c5d9ba0 
…f it (#1923)

* #1921: refactor info panel and fix bug with cropped expanded molecules

* #1921: small tweak

* #1921: add more tools

* #1921: fix zoom

* #1921: review comments

* #1920 – added abbreviation to Struct, fixed isSaltOrSolvent check

* #1912: fix missing first atom in sGroup

* #1912: fix showing popup for salts and solvents

* #1912: small tweak

* #1912: fix bug with determining salts

* #1912: fix merge

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1920 Salts and Solvents tab: Abbreviation is expanded after adding to the canvas epam/ketcher
3 participants
@Nitvex @Zhirnoff @KonstantinEpam23