Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SMILES: Pasting structure with small letters throw an error #1986

Closed
Zhirnoff opened this issue Dec 23, 2022 · 0 comments · Fixed by #1991
Closed

SMILES: Pasting structure with small letters throw an error #1986

Zhirnoff opened this issue Dec 23, 2022 · 0 comments · Fixed by #1991
Assignees
@Nitvex
Labels
bug
Milestone
Release 2.7.0

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Launch Ketcher
  2. Paste in Clipboard: Brc1ccc(COC(Cn2ccnc2)c2ccc(Cl)cc2Cl)c(Cl)c1
  3. Look at structure
    Note: I noticed that if there are atoms in the structure that contain small letters in the name, then this error appears
    This bug is not reproducible on Ketcher version 2.6.1

Expected behavior
Structure displayed on canvas
2022-12-23_10h29_53

Actual behavior

Error Message: Cannot read properties of undefined (reading 'slice')

Attachments

2022-12-23_10h10_31

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 108.0.5359.125 (Official Build) (64-bit)

Ketcher version
Version 2.7.0-rc.5

Additional context
Add any other context about the problem here.
@Zhirnoff Zhirnoff added this to the Release 2.7.0 milestone Dec 23, 2022
Nitvex added a commit that referenced this issue Dec 23, 2022
@Nitvex
#1986 – SMILES: Pasting structure with small letters throw an error
e4f1162
@Nitvex Nitvex mentioned this issue Dec 23, 2022
Merged
@Nitvex Nitvex linked a pull request Dec 23, 2022 that will close this issue
#1986 – SMILES: Pasting structure with small letters throw an error #1991
Merged
Nitvex added a commit that referenced this issue Dec 23, 2022
@Nitvex
#1986 – SMILES: Pasting structure with small letters throw an error (#…
3ccacf6 
…1991)
@Nitvex Nitvex closed this as completed Dec 23, 2022
Nitvex added a commit that referenced this issue Dec 23, 2022
@Nitvex
#1986 – SMILES: Pasting structure with small letters throw an error (#…
94cc3ce 
…1991)
Nitvex added a commit that referenced this issue Dec 23, 2022
@Nitvex
Backmerge: #1986 – SMILES: Pasting structure with small letters throw…
121f638 
… an error (#1991)
Nitvex added a commit that referenced this issue Dec 23, 2022
@Nitvex
Backmerge: #1986 – SMILES: Pasting structure with small letters throw…
c45aa4f 
… an error (#1991) (#1993)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug
Projects
None yet
Milestone
Release 2.7.0
Development

Successfully merging a pull request may close this issue.

#1986 – SMILES: Pasting structure with small letters throw an error epam/ketcher
2 participants
@Nitvex @Zhirnoff