Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abbreviations: Atoms protrude beyond the expanded view for Functional Groups and Salts and Solvents #2033

Closed
Zhirnoff opened this issue Dec 29, 2022 · 1 comment · Fixed by #2125
Closed

Abbreviations: Atoms protrude beyond the expanded view for Functional Groups and Salts and Solvents #2033

Zhirnoff opened this issue Dec 29, 2022 · 1 comment · Fixed by #2125
Assignees
@TimSPb89
Labels
bug
Milestone
Ketcher 2.9.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Dec 29, 2022 •
edited
Loading

Steps to Reproduce

  1. Launch Ketcher
  2. Press 'Custom Templates' button and click on 'Functional Groups' tab
  3. Select for example 'CO2tBu' and add to canvas
  4. Press 'Custom Templates' button and click on 'Salts and Solvents' tab
  5. Select for example 'methane sulphonic acid' and add to canvas
  6. Expand the abbreviations and look at appeared images

Actual behavior
Expand abbreviation for Functional Groups and Salts and Solvents works incorrectly - atoms protrude beyond the expanded view

Expected behavior
Expand abbreviation for Functional Groups and Salts and Solvents works correctly - atoms not protrude beyond the expanded view. The whole structure fits into an expand square.

Screenshots
2022-12-29_14h51_14

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 108.0.5359.125 (Official Build) (64-bit)

Ketcher version
Version 2.7.0-rc.8
@Zhirnoff Zhirnoff added the bug label Dec 29, 2022
@Zhirnoff Zhirnoff added this to the Release 2.8.0 milestone Dec 29, 2022
@Nitvex
Copy link
Collaborator

Nitvex commented Jan 13, 2023

Issue is reproduced in v2.7.0-rc.9, moving to v2.9.0-rc.1

@KonstantinEpam23 KonstantinEpam23 assigned TimSPb89 and unassigned Nitvex Jan 17, 2023
TimSPb89 added a commit that referenced this issue Jan 25, 2023
@TimSPb89
#2033 - Abbreviations: Atoms protrude beyond the expanded view for Fu…
c3c5bce 
…nctional Groups and Salts and Solvents
TimSPb89 added a commit that referenced this issue Jan 25, 2023
@TimSPb89
#2033 - review fix
5f7bbf1
TimSPb89 added a commit that referenced this issue Jan 25, 2023
@TimSPb89
#2033 - one more place to restore saved selection tool
83ae3f3
@TimSPb89 TimSPb89 mentioned this issue Jan 25, 2023
Merged
KonstantinEpam23 pushed a commit that referenced this issue Jan 25, 2023
@TimSPb89
#1818: Persist user settings (#2097)
ccc164e 
* #1818 - Persist user settings

* #1818 - fixed missing check

* #2033 - review fix

* #2033 - one more place to restore saved selection tool
TimSPb89 added a commit that referenced this issue Jan 26, 2023
@TimSPb89
#2033 - review fixes
5d3f4b2
TimSPb89 added a commit that referenced this issue Jan 26, 2023
@TimSPb89
#2033 - review fix (replaced in with instanceof check)
3b983e8
TimSPb89 added a commit that referenced this issue Jan 27, 2023
@TimSPb89
Revert "#2033 - review fix (replaced in with instanceof check)" to fi…
05d5be5 
…x the build failure

This reverts commit 3b983e8.
KonstantinEpam23 pushed a commit that referenced this issue Feb 3, 2023
@TimSPb89
#2033: Abbreviations: Atoms protrude beyond the expanded view (#2125)
5016dee 
* #2033 - Abbreviations: Atoms protrude beyond the expanded view for Functional Groups and Salts and Solvents

* #2033 - review fixes

* #2033 - review fix (replaced in with instanceof check)

* Revert "#2033 - review fix (replaced in with instanceof check)" to fix the build failure

This reverts commit 3b983e8.
@KonstantinEpam23 KonstantinEpam23 mentioned this issue Feb 3, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimSPb89 TimSPb89

Labels
bug
Projects
None yet
Milestone
Ketcher 2.9.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2033: Abbreviations: Atoms protrude beyond the expanded view epam/ketcher
3 participants
@TimSPb89 @Nitvex @Zhirnoff