Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't break the selection if the user's cursor goes beyond the canvas #2060

Closed
Nitvex opened this issue Jan 6, 2023 · 0 comments · Fixed by #2071
Closed

Don't break the selection if the user's cursor goes beyond the canvas #2060

Nitvex opened this issue Jan 6, 2023 · 0 comments · Fixed by #2071
Assignees
@St-Permiakov
Milestone
Release Candidate...

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Jan 6, 2023 •
edited
Loading

Is your feature request related to a problem? Please describe.
Select the 'Selection Tool', then try to select a structure, which is near to the edge of the canvas. At the current moment, if a users cursor will appear out of canvas, then 'Selection Tool' is stopped and selection is interrupted.
It is required not to interrupt selection tool, when user moved cursor beyond the canvas.
@Nitvex Nitvex added this to the Release 2.8.0 milestone Jan 6, 2023
@Nitvex Nitvex self-assigned this Jan 6, 2023
@St-Permiakov St-Permiakov assigned St-Permiakov and unassigned Nitvex Jan 6, 2023
St-Permiakov pushed a commit that referenced this issue Jan 9, 2023
#2060 — Don't break the selection if the user's cursor goes beyond th…
79907a3 
…e canvas
@St-Permiakov St-Permiakov mentioned this issue Jan 9, 2023
Merged
St-Permiakov pushed a commit that referenced this issue Jan 10, 2023
#2060 - fix redundant store update on mouseup
eaa2bff
St-Permiakov pushed a commit that referenced this issue Jan 10, 2023
#2060 - fix redundant actions on mouse events when not over canvas
35c91bb
St-Permiakov pushed a commit that referenced this issue Jan 10, 2023
#2060 — Don't break the selection if the user's cursor goes beyond th…
24e78e2 
…e canvas
St-Permiakov pushed a commit that referenced this issue Jan 10, 2023
#2060 - fix redundant actions on mouse events when not over canvas
838bf08
Nitvex pushed a commit that referenced this issue Jan 10, 2023
@St-Permiakov
#2060: Don't break the selection if the user's cursor goes beyond the…
248f71d 
… canvas (#2071)

* #2060 — Don't break the selection if the user's cursor goes beyond the canvas

* #2060 - fix redundant actions on mouse events when not over canvas

Co-authored-by: Stanislav Permiakov <Stanislav.Permiakov@primark.onmicrosoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@St-Permiakov St-Permiakov

Labels
None yet
Projects
None yet
Milestone
Release Candidate 2.8.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2060: Don't break the selection if the user's cursor goes beyond the canvas epam/ketcher
2 participants
@St-Permiakov @Nitvex