Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Using paste tool (or new template tool) - clearing the canvas causes console errors #2091

Closed
KonstantinEpam23 opened this issue Jan 13, 2023 · 2 comments · Fixed by #2102
Closed

Using paste tool (or new template tool) - clearing the canvas causes console errors #2091

KonstantinEpam23 opened this issue Jan 13, 2023 · 2 comments · Fixed by #2102
Assignees
@ansivgit
Labels
bug
Milestone
Release Candidate...

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented Jan 13, 2023 •
edited
Loading

Steps to Reproduce

  1. Open browser console
  2. Paste a molecule
  3. Click on "clear canvas"

Actual behavior
Multiple type errors appear in the console

Expected behavior
Errors should not appear in the console

Screenshots
212008181-5f3116c8-be19-468e-907a-cc6cd95f8acd

Ketcher version
v2.8.0

Additional context
Add any other context about the problem here.
@KonstantinEpam23 KonstantinEpam23 changed the title Using paste tool - clearing the canvas causes console errors Using paste tool (or new template tool) - clearing the canvas causes console errors Jan 13, 2023
@Nitvex
Copy link
Collaborator

Nitvex commented Jan 13, 2023

Issue is NOT reproduced in v2.7.0-rc.9

@ansivgit ansivgit self-assigned this Jan 16, 2023
@KonstantinEpam23
Copy link
Collaborator Author

Issue is NOT reproduced in v2.7.0-rc.9

Updated description to say 2.8.0

ansivgit added a commit that referenced this issue Jan 17, 2023
@ansivgit
#2091 add exeptions handle
7f96f17
@ansivgit ansivgit mentioned this issue Jan 17, 2023
Merged
@ansivgit ansivgit linked a pull request Jan 17, 2023 that will close this issue
#2091 Using paste tool (or new template tool) - clearing the canvas causes console errors #2102
Merged
ansivgit added a commit that referenced this issue Jan 17, 2023
@ansivgit
#2091 add try catchfor assertion
4a9849e
ansivgit added a commit that referenced this issue Jan 18, 2023
@ansivgit
#2091 remove one line if
1d1c0d2
@yuleicul yuleicul mentioned this issue Jan 19, 2023
Merged
KonstantinEpam23 added a commit that referenced this issue Jan 25, 2023
@KonstantinEpam23
#2091: remove commented if
868bf3a
KonstantinEpam23 added a commit that referenced this issue Jan 25, 2023
@ansivgit @KonstantinEpam23
#2091: Using paste tool (or new template tool) - clearing the canvas …
e60153e 
…causes console errors

* #2091 add exeptions handle

* #2091 add try catchfor assertion

* #2091 remove one line if

* #2091: remove commented if

Co-authored-by: Konstantin Levin <yemsalat.me@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ansivgit ansivgit

Labels
bug
Projects
None yet
Milestone
Release Candidate 2.8.0-rc.1
3 participants
@Nitvex @ansivgit @KonstantinEpam23