Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hovered structure gets into the saved molecule #2113

Closed
yuleicul opened this issue Jan 20, 2023 · 2 comments · Fixed by #2119, #2555 or #2556
Closed

Hovered structure gets into the saved molecule #2113

yuleicul opened this issue Jan 20, 2023 · 2 comments · Fixed by #2119, #2555 or #2556
Labels
bug
Milestone
Ketcher 2.10.0-rc.2

Comments

@yuleicul
Copy link
Collaborator

yuleicul commented Jan 20, 2023 •
edited
Loading

Steps to Reproduce

  1. Click the tool Single Bond
  2. Click on the canvas to draw a structure
  3. Click the tool Selection, and select the structure drawn on step 2
  4. Press Ctrl+x to cut it
  5. Press Ctrl+v, but do not click on the canvas (means you haven't yet decided to paste it)
  6. Press Ctrl+s

Actual behavior
You can see the data of the structure(which you haven't pasted on the canvas) shows on the preview text

Expected behavior
The data of the structure(which you haven't pasted on the canvas) doesn't show on the preview text

Screenshots
ketcher-paste-bug-10

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version [e.g. v2.4.2].
v2.7.0 rc.10

Additional context
Originally posted by @KonstantinEpam23 in #2079 (comment)
@yuleicul yuleicul added this to the Release Candidate 2.8.0-rc.1 milestone Jan 20, 2023
@yuleicul yuleicul mentioned this issue Jan 20, 2023
Merged
@Nitvex Nitvex added the bug label Jan 20, 2023
@yuleicul yuleicul mentioned this issue Jan 20, 2023
Merged
@yuleicul yuleicul linked a pull request Jan 20, 2023 that will close this issue
#2113 Hovered structure gets into the saved molecule #2119
Merged
yuleicul added a commit that referenced this issue Feb 6, 2023
@yuleicul
Merge branch 'master' into #2113-hovered-structure-gets-into-the-save…
562cf34 
…d-molecule
yuleicul added a commit that referenced this issue Feb 21, 2023
@yuleicul
Merge branch 'master' into #2113-hovered-structure-gets-into-the-save…
3b412e3 
…d-molecule
@Zhirnoff
Copy link
Collaborator

Templates, Template Library structures, Functional Groups, Salts and Solvents, if they are under cursor at time of saving file, then get into the saved file.
Steps for Reproduce:

  1. Select any Template (e.g. Benzene)
  2. Do not put on canvas
  3. Click 'Save' button or CTRL+S
  4. Look at preview for saved file
  5. Repeat steps 2-4 for Library structures, Functional Group and Salts and Solvents
2023-03-14_18h58_49.mp4

Ketcher version
Version 2.9.0-rc.3

Nitvex added a commit that referenced this issue Mar 22, 2023
@yuleicul @Nitvex
#2113 Hovered structure gets into the saved molecule (#2119)
bba4bc9 
* Fix hovered structure getting into saving

* Fix typo

Co-authored-by: Nikita <Nikita_Vozisov@epam.com>

* Update variable name

---------

Co-authored-by: Nikita <Nikita_Vozisov@epam.com>
@Zhirnoff
Copy link
Collaborator

Bug reproduces in 2.10.0-rc.1

2023-04-27_20h06_00.mp4
2023-04-27_20h08_16.mp4

@Zhirnoff Zhirnoff reopened this Apr 27, 2023
@Nitvex Nitvex assigned ghost and unassigned yuleicul Apr 28, 2023
ghost pushed a commit that referenced this issue Apr 28, 2023
@VandaEPAM
#2113 - added remove-not-rendered-struct action
64dcb2d
@ghost ghost linked a pull request Apr 28, 2023 that will close this issue
#2113 Hovered structure gets into the saved molecule #2555
Merged
ghost pushed a commit that referenced this issue May 1, 2023
@VandaEPAM
#2113 - Added remove struct action
5fe7b3b
Nitvex pushed a commit that referenced this issue May 1, 2023
#2113 Hovered structure gets into the saved molecule (#2555)
8f0085c 
* #2113 - added remove-not-rendered-struct action

* #2113 - Added remove struct action
Nitvex pushed a commit that referenced this issue May 1, 2023
@Nitvex
Backmerge: #2113 Hovered structure gets into the saved molecule (#2555)
3e8c1a9 
* #2113 - added remove-not-rendered-struct action

* #2113 - Added remove struct action
@Nitvex Nitvex mentioned this issue May 1, 2023
Merged
Nitvex added a commit that referenced this issue May 1, 2023
@Nitvex
Backmerge: #2113 Hovered structure gets into the saved molecule (#2555)…
455a68c 
… (#2556)

* #2113 - added remove-not-rendered-struct action

* #2113 - Added remove struct action

Co-authored-by: VandaPonikarova <124260809+VandaPonikarova@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
Ketcher 2.10.0-rc.2
4 participants
@yuleicul @Nitvex @Zhirnoff @KonstantinEpam23