Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If structure contains SRU-Group User can't click 'Calculated Values' button - nothing happens after clicking. #215

Closed
Ksanjara opened this issue Dec 28, 2020 · 2 comments · Fixed by #252
Closed

If structure contains SRU-Group User can't click 'Calculated Values' button - nothing happens after clicking. #215

Ksanjara opened this issue Dec 28, 2020 · 2 comments · Fixed by #252
Assignees
@Ksanjara @ensemenova
Labels
bug
Milestone
Standalone Mode

Comments

@Ksanjara
Copy link

Affected Version: Standalone , Remote (Multiple S-Groups)
Steps to Reproduce:

  1. Create chain structure.
  2. Add SRU-polymer S-Group.
  3. Click 'Calculated Values' button.

Expected Result:
In 'Chemical Formula' field displays correct formula, all another fields contains message: "error: Cannot calculate mass for structure with repeating units"
remote

Actual Result:
If structure contains SRU-Group User can't click 'Calculated Values' button - nothing happens after clicking. The same behavior is with Multiple S-Groups that are on the end of Structure. (Multiple S-Groups behavior reproduces in Remote mode too.)
@Ksanjara Ksanjara added the bug label Dec 28, 2020
@Ksanjara Ksanjara added this to the Standalone mode milestone Dec 28, 2020
@AndreiMazol AndreiMazol self-assigned this Dec 30, 2020
ensemenova added a commit that referenced this issue Jan 18, 2021
@ensemenova
#215 Show error to user
00851cb
@ensemenova ensemenova mentioned this issue Jan 18, 2021
Merged
@ensemenova ensemenova linked a pull request Jan 18, 2021 that will close this issue
#215 Show error to user in case any error happened during calculating values #252
Merged
@ensemenova
Copy link
Contributor

Here is 2 independent cases.

  1. Standalone and SRU-Group in the middle. Caused by Indigo JS and server version returns different response in case of error in molecule  Indigo#299. When the linked ticket will be fixed, behavior would be the same as on Remote
  2. Standalone and Remove and SRU-Group at the end of the structure. Caused by invalid molecule structure, in this case molecule even couldn't be saved. Enhancement suggested Add a marker on UI which shows if current molecule is valid or not #251

For now both cases were improved with showing error message to user.

ensemenova added a commit that referenced this issue Jan 19, 2021
@ensemenova
#215 Move todo to separate line
5f55f4b
AndreiMazol pushed a commit that referenced this issue Jan 19, 2021
@ensemenova
#215 Show error to user in case any error happened during calculating…
7b77559 
… values (#252)

* Show alert message if error is thrown

* Move todo to separate line
@Ksanjara
Copy link
Author

Issue is closed as partially fixed.
When Structure contains SRU-polymer group on the end of Structure now error message appears.
When Structure in Standalone mode contains SRU-polymer group in the middle of Structure - 'Calculated Values' window opens with zero values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ksanjara Ksanjara

@ensemenova ensemenova

Labels
bug
Projects
None yet
Milestone
Standalone Mode
Development

Successfully merging a pull request may close this issue.

#215 Show error to user in case any error happened during calculating values epam/ketcher
3 participants
@AndreiMazol @Ksanjara @ensemenova