Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

library.svg file for templates does not seem to be used #2177

Closed
KonstantinEpam23 opened this issue Feb 6, 2023 · 2 comments · Fixed by #3973 or #3994
Closed

library.svg file for templates does not seem to be used #2177

KonstantinEpam23 opened this issue Feb 6, 2023 · 2 comments · Fixed by #3973 or #3994
Assignees
@bklimov-web
Labels
feature request technical debt
Milestone
Ketcher 2.18.0-rc.3

Comments

@KonstantinEpam23
Copy link
Collaborator

Background
library.svg file seems to be storing pre-rendered svg templates from library.sdf
At the moment the templates sdf file includes bindings to library.svg file, but it does not seem like the prerendered elements are being used, meanwhile the file weighs around 2.5MB and slows down initial page loading.
Screenshot 2023-02-06 at 11 31 31

Solution
Investigate if library.svg file is used, if it is - introduce gzip and caching on the infrastructure level for this file, if not - remove the file and do not request it from the client side.
@KonstantinEpam23 KonstantinEpam23 added this to the Refined Backlog milestone Feb 6, 2023
@KonstantinEpam23 KonstantinEpam23 self-assigned this Feb 6, 2023
@KonstantinEpam23
Copy link
Collaborator Author

Could relate to #2598

@rrodionov91
Copy link
Collaborator

library.svg usage was removed in #900
It needs to remove file.

bklimov-web added a commit that referenced this issue Jan 26, 2024
@bklimov-web
#2177 - remove library.svg and all its references
8f1676d
@bklimov-web bklimov-web linked a pull request Jan 26, 2024 that will close this issue
#2177 - library.svg removal #3973
Merged
9 tasks
rrodionov91 pushed a commit that referenced this issue Jan 30, 2024
@bklimov-web
#2177 - remove library.svg and all its references (#3973)
1caaf2b
rrodionov91 pushed a commit that referenced this issue Jan 30, 2024
@bklimov-web @rrodionov91
#2177 - remove library.svg and all its references
a7f8e79
@rrodionov91 rrodionov91 linked a pull request Jan 30, 2024 that will close this issue
#2177 - library.svg file for templates does not seem to be used #3994
Merged
9 tasks
rrodionov91 added a commit that referenced this issue Jan 30, 2024
@rrodionov91 @bklimov-web
#2177 - remove library.svg and all its references (#3994)
fa8093b 
Co-authored-by: bklimov-web <Bogdan_Klimov@epam.com>
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bklimov-web bklimov-web

Labels
feature request technical debt
Projects
Ketcher
Status: Done
Technical Debt
Status: Done
Milestone
Ketcher 2.18.0-rc.3
3 participants
@rrodionov91 @bklimov-web @KonstantinEpam23