Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When user hovers cursor with any template selected near the border of the canvas scrollbars appear #2325

Closed
d-mrzv opened this issue Mar 13, 2023 · 1 comment · Fixed by #2346 or #2361
Closed

When user hovers cursor with any template selected near the border of the canvas scrollbars appear #2325

d-mrzv opened this issue Mar 13, 2023 · 1 comment · Fixed by #2346 or #2361
Assignees
@Nitvex
Labels
bug Priority: High regression Issue was found during regression
Milestone
Ketcher 2.9.0-rc.4

Comments

@d-mrzv
Copy link
Collaborator

d-mrzv commented Mar 13, 2023 •
edited by Zhirnoff
Loading

Steps to Reproduce

  1. Go to https://rc.test.lifescience.opensource.epam.com/KetcherDemoSA/index.html
  2. Select any template from template palette or custom templates
  3. Move mouse cursor to any border of the canvas

Actual behavior
Scrollbars appear when cursor with structure is near the border of the canvas

Expected behavior
Either not let user to move structure when it overlaps the canvas borders or automatically scroll the canvas

Screenshots
https://user-images.githubusercontent.com/124911723/224676562-3212bfff-4c76-4457-9bee-37ce86918a96.mov

Desktop (please complete the following information):

  • OS: macos 13.2.1 (22D68)
  • Browser Chrome
  • Version 110.0.5481.177 (Official Build) (x86_64)

Ketcher version [e.g. v2.4.2].
[Version 2.9.0-rc.3]

Test case
EPMLSOPKET-10120
Related issue: #2114

#184705286
@d-mrzv d-mrzv added the bug label Mar 13, 2023
@d-mrzv d-mrzv added this to the Ketcher 2.9.0-rc.4 milestone Mar 13, 2023
@Zhirnoff
Copy link
Collaborator

The structure shifts on the canvas when trying to select something from the toolbar when the template is selected

2023-03-13_14h22_55.mp4

@Zhirnoff Zhirnoff mentioned this issue Mar 13, 2023
Closed
Nitvex added a commit that referenced this issue Mar 13, 2023
@Nitvex
#2325 – When user hovers cursor with any template selected near the b…
bb085c8 
…order of the canvas scrollbars appear
@Nitvex Nitvex mentioned this issue Mar 14, 2023
Merged
@Nitvex Nitvex linked a pull request Mar 14, 2023 that will close this issue
#2325 – When user hovers cursor with any template selected near the border of the canvas scrollbars appear #2346
Merged
Nitvex added a commit that referenced this issue Mar 15, 2023
@Nitvex
#2325 – When user hovers cursor with any template selected near the …
a96212a 
…border of the canvas scrollbars appear
Nitvex added a commit that referenced this issue Mar 15, 2023
@Nitvex
#2325 – When user hovers cursor with any template selected near the …
54066e2 
…border of the canvas scrollbars appear (#2346)
Nitvex added a commit that referenced this issue Mar 15, 2023
@Nitvex
Backmerge: #2325 – When user hovers cursor with any template selected…
54a5921 
… near the border of the canvas scrollbars appear (#2346)
@Nitvex Nitvex linked a pull request Mar 15, 2023 that will close this issue
Backmerge: #2325 – When user hovers cursor with any template selected near the border of the canvas scrollbars appear (#2346) #2361
Merged
@Nitvex Nitvex mentioned this issue Mar 15, 2023
Merged
@Nitvex Nitvex closed this as completed Mar 15, 2023
Nitvex added a commit that referenced this issue Mar 15, 2023
@Nitvex
Backmerge: #2325 – When user hovers cursor with any template selected…
cedfabe 
… near the border of the canvas scrollbars appear (#2346) (#2361)
KonstantinEpam23 pushed a commit that referenced this issue Mar 16, 2023
@Nitvex @KonstantinEpam23
Backmerge: #2325 – When user hovers cursor with any template selected…
4ce3ff1 
… near the border of the canvas scrollbars appear (#2346) (#2361)

shrinkwrap / test 1

shrinkwrap / test 3

shrinkwrap / test 4

shrinkwrap / test 5

shrinkwrap / test 6

shrinkwrap / test 7 : NO prettier

shrinkwrap / test 8

shrinkwrap / test 9

shrinkwrap / test 10

shrinkwrap / test 11

shrinkwrap / test 12

shrinkwrap / test 13

shrinkwrap / test 14
@Zhirnoff Zhirnoff added the regression Issue was found during regression label Mar 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug Priority: High regression Issue was found during regression
Projects
None yet
Milestone
Ketcher 2.9.0-rc.4
4 participants
@Nitvex @Zhirnoff @KonstantinEpam23 @d-mrzv