Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotkey (Del) can't delete Functional Groups and Salts abbreviation #2420

Closed
Zhirnoff opened this issue Mar 27, 2023 · 1 comment · Fixed by #2478, #2562 or #2564
Closed

Hotkey (Del) can't delete Functional Groups and Salts abbreviation #2420

Zhirnoff opened this issue Mar 27, 2023 · 1 comment · Fixed by #2478, #2562 or #2564
Assignees
@Ziprion
Labels
bug
Milestone
Ketcher 2.10.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add Functional Groups and Salts abbreviations on canvas
  3. Hover mouse over Functional Groups and Salts abbreviations and press hotkey (Del)

Actual behavior
Functional Groups and Salts abbreviations are not deleted

Expected behavior
Functional Groups and Salts abbreviations are deleted

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.9.0-rc.5
@Zhirnoff Zhirnoff added the bug label Mar 27, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.10.0-rc.1 milestone Mar 27, 2023
@Nitvex Nitvex assigned Ziprion and unassigned Nitvex Apr 10, 2023
Ziprion pushed a commit that referenced this issue Apr 12, 2023
#2420 - hotkey del can not delete functional groups and salts abbrevi…
6af9092 
…ation
@Ziprion Ziprion mentioned this issue Apr 12, 2023
Merged
Ziprion pushed a commit that referenced this issue Apr 13, 2023
#2420 - fix bonds iteration
64c78f0
Ziprion pushed a commit that referenced this issue Apr 18, 2023
Merge branch 'master' into #2420-hotkey-del-can-not-delete-functional…
6fda701 
…-groups-and-salts-abbreviation
Ziprion pushed a commit that referenced this issue Apr 18, 2023
#2420 - change variable name
45a8f68
Nitvex pushed a commit that referenced this issue Apr 19, 2023
@Ziprion
#2420 Hotkey (Del) can't delete Functional Groups and Salts abbreviat…
6f365bc 
…ion (#2478)

* #2420 - hotkey del can not delete functional groups and salts abbreviation

* #2420 - fix bonds iteration

* #2420 - change variable name

---------

Co-authored-by: Maxim Novikov <Maxim_Novikov@epam.com>
@Zhirnoff
Copy link
Collaborator Author

A contracted function group abbreviation is removed with the DEL hotkey. But now it became possible to delete parts of the expanded functional group or salt with the DEL hotkey. When trying to change the functional group or salt, a warning window should appear (EDIT ABBREVIATION)

2023-04-24_14h06_02.mp4

@Zhirnoff Zhirnoff reopened this Apr 24, 2023
Ziprion pushed a commit that referenced this issue Apr 26, 2023
#2420 - hotkey del can not delete functional groups and salts abbrevi…
12d076c 
…ation
@Ziprion Ziprion mentioned this issue Apr 26, 2023
Closed
Ziprion pushed a commit that referenced this issue Apr 26, 2023
#2420 - fix deleting behavior
c981d90
ghost pushed a commit that referenced this issue May 1, 2023
@VandaEPAM
#2420 - hotkey del can not delete functional groups and salts abbrevi…
17f1526 
…ation
ghost pushed a commit that referenced this issue May 1, 2023
@VandaEPAM
#2420 - fix deleting behavior
fdcd149
ghost pushed a commit that referenced this issue May 1, 2023
@VandaEPAM
#2420 - Added struct type const
4c354d2
@ghost ghost linked a pull request May 1, 2023 that will close this issue
#2420: Hotkey (Del) can't delete Functional Groups and Salts abbreviation #2562
Merged
Nitvex pushed a commit that referenced this issue May 1, 2023
#2420: Hotkey (Del) can't delete Functional Groups and Salts abbrevia…
6600235 
…tion (#2562)

* #2420 - hotkey del can not delete functional groups and salts abbreviation

* #2420 - fix deleting behavior

* #2420 - Added struct type const

---------

Co-authored-by: Maxim Novikov <Maxim_Novikov@epam.com>
ghost pushed a commit that referenced this issue May 1, 2023
@VandaEPAM
Backmerge: #2420 - Hotkey (Del) can't delete Functional Groups and Sa…
ef8ee92 
…lts abbreviation
@ghost ghost mentioned this issue May 1, 2023
Merged
Nitvex pushed a commit that referenced this issue May 2, 2023
Backmerge: #2420 - Hotkey (Del) can't delete Functional Groups and Sa…
49cb208 
…lts abbreviation (#2564)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ziprion Ziprion

Labels
bug
Projects
None yet
Milestone
Ketcher 2.10.0-rc.2
3 participants
@Nitvex @Zhirnoff @Ziprion