Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'Cancel' button does not reverse adding Template to expanded and contracted Functional Group #2425

Closed
Zhirnoff opened this issue Mar 29, 2023 · 0 comments · Fixed by #2444 or #2445
Closed

The 'Cancel' button does not reverse adding Template to expanded and contracted Functional Group #2425

Zhirnoff opened this issue Mar 29, 2023 · 0 comments · Fixed by #2444 or #2445
Assignees
@Konstantin1996
Labels
bug
Milestone
Ketcher 2.9.0-rc.6

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Mar 29, 2023 •
edited
Loading

Steps to Reproduce
Scenario 1

  1. Open Ketcher
  2. Add contracted Functional Group on canvas
  3. Select Template (e.g. Benzene) and click on FG

Actual behavior

EDIT ABBREVIATION window appears. After pressing 'Cancel' Template remains on the abbreviation and can only spin.
Note: if you press 'Undo' on the top panel, then errors appear in the DevTool console

Expected behavior
EDIT ABBREVIATION window appears. After pressing 'Cancel' Template not added to Functional Group.

Scenario 2

  1. Open Ketcher
  2. Add expanded Functional Group on canvas
  3. Select Template (e.g. Benzene) and click on FG

Actual behavior

EDIT ABBREVIATION window appears. After pressing 'Cancel' Template remains on the abbreviation and can only spin.
Note: if you press 'Undo' on the top panel, then many errors appear in the DevTool console
Expected behavior
EDIT ABBREVIATION window appears. After pressing 'Cancel' Template not added to expanded Functional Group.

Scenario 3

  1. Open Ketcher
  2. Add expanded Functional Group on canvas
  3. Select Functional Group (e.g. Bn) and click on expanded FG

Actual behavior

EDIT ABBREVIATION window does not appears. Functional Group is added forming square brackets

Expected behavior
EDIT ABBREVIATION window appears. After pressing 'Cancel' functional group not added to expanded Functional Group.

Screenshots

2023-03-28_21h55_14.mp4
2023-03-28_22h22_27.mp4
2023-03-28_22h25_03.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.9.0-rc.5
@Zhirnoff Zhirnoff added the bug label Mar 29, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.9.0-rc.6 milestone Mar 29, 2023
@Zhirnoff Zhirnoff changed the title The 'Cancel' button does not reverse adding Template to expanded Functional Group The 'Cancel' button does not reverse adding Template to expanded and contracted Functional Group Mar 29, 2023
@Nitvex Nitvex assigned Konstantin1996 and unassigned Nitvex Mar 30, 2023
@Konstantin1996 Konstantin1996 linked a pull request Apr 4, 2023 that will close this issue
#2425 - The 'Cancel' button does not reverse adding Template to expanded and contracted Functional Group #2443
Closed
@Konstantin1996 Konstantin1996 linked a pull request Apr 4, 2023 that will close this issue
#2425 - The 'Cancel' button does not reverse adding Template to expanded and contracted Functional Group #2444
Merged
Konstantin1996 pushed a commit that referenced this issue Apr 4, 2023
Backmerge: #2425-the-cancel-button-does-not-reverse-adding-template-t…
697c016 
…o-expanded-and-contracted-functional-group-main

- changed logic of the mouse down (add async await)
- created getter isModeFunctionalGroup
- created separate method showRemoveAbbreviationPopup to trigger popup
- created constants
@Konstantin1996 Konstantin1996 linked a pull request Apr 4, 2023 that will close this issue
Backmerge: #2425-the-cancel-button-does-not-reverse-adding-template-to-expanded-and-contracted-functional-group-main #2445
Merged
KonstantinEpam23 pushed a commit that referenced this issue Apr 6, 2023
@Konstantin1996
#2425 - changed logic of the mouse down (add async await) (#2444)
e4d8673 
- created getter isModeFunctionalGroup
- created separate method showRemoveAbbreviationPopup to trigger popup
- created constants

Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
KonstantinEpam23 pushed a commit that referenced this issue Apr 6, 2023
@Konstantin1996
Backmerge: #2425-the-cancel-button-does-not-reverse-adding-template-t…
e10d44d 
…o-expanded-and-contracted-functional-group-main (#2445)

- changed logic of the mouse down (add async await)
- created getter isModeFunctionalGroup
- created separate method showRemoveAbbreviationPopup to trigger popup
- created constants

Co-authored-by: Konstantin Zharich <kostantin_zharich@epam.com>
@kaluginserg kaluginserg mentioned this issue May 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Konstantin1996 Konstantin1996

Labels
bug
Projects
None yet
Milestone
Ketcher 2.9.0-rc.6
4 participants
@Konstantin1996 @Nitvex @Zhirnoff @KonstantinEpam23