Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add possibility to hide buttons on control panel #244

Closed
AndreiMazol opened this issue Jan 15, 2021 · 2 comments · Fixed by #259, #264, #285 or #332
Closed

Add possibility to hide buttons on control panel #244

AndreiMazol opened this issue Jan 15, 2021 · 2 comments · Fixed by #259, #264, #285 or #332
Assignees
@tomas-light @Ksanjara
Labels
enhancement

Comments

@AndreiMazol
Copy link
Contributor

Standalone mode does not support recognize functionality now. It necessary to have hide the following buttons to not confuse end users:

  • recognize button (while wasm module does not support it)
  • 3D Miew viewer

Scope:

  1. Hide buttons
  2. Add configuration property to allow to hide any buttons (and exclude required dependencies from resulted bundle)
@AndreiMazol AndreiMazol added this to the Standalone mode milestone Jan 15, 2021
@AndreiMazol AndreiMazol self-assigned this Jan 15, 2021
tomas-light added a commit that referenced this issue Jan 20, 2021
@tomas-light
#244 add ability to hide recognize and miew buttons, move Ketcher cla…
e5e187d 
…ss to separated file
tomas-light added a commit that referenced this issue Jan 20, 2021
@tomas-light
#244 add button name type
32a1828
tomas-light added a commit that referenced this issue Jan 20, 2021
@tomas-light
#244 add optional flag to interface properties
f2bfc51
@tomas-light tomas-light linked a pull request Jan 21, 2021 that will close this issue
#244 hide control panel buttons #259
Merged
AndreiMazol pushed a commit that referenced this issue Jan 21, 2021
@tomas-light
#244 hide control panel buttons (#259)
91e289e 
* add ability to hide recognize and miew buttons, move Ketcher class to separated file

* add button name type

* add optional flag to interface properties

* review fixes
ensemenova pushed a commit that referenced this issue Jan 21, 2021
@tomas-light @ensemenova
#244 hide control panel buttons (#259)
51284a4 
* add ability to hide recognize and miew buttons, move Ketcher class to separated file

* add button name type

* add optional flag to interface properties

* review fixes
tomas-light added a commit that referenced this issue Jan 21, 2021
@tomas-light
#244 fix error, when global.ketcher.editor try assign before `globa…
026f3a3 
…l.ketcher` was setted
@tomas-light tomas-light linked a pull request Jan 21, 2021 that will close this issue
#244 fix error, when global.ketcher.editor try assign before global.ketcher was setted #264
Merged
tomas-light added a commit that referenced this issue Jan 21, 2021
@tomas-light
#244 code style
797794c
AndreiMazol pushed a commit that referenced this issue Jan 22, 2021
@tomas-light
#244 fix error, when global.ketcher.editor try assign before `globa…
cf02709 
…l.ketcher` was setted (#264)

* #244 fix error, when `global.ketcher.editor` try assign before `global.ketcher` was setted

* #244 code style
@Ksanjara
Copy link

Ksanjara commented Jan 27, 2021 •
edited
Loading

Issue is verified and closed.

Screenshot 2021-01-27 160413

@Ksanjara
Copy link

After disсussion issue is reopened.
Needs interface changes

@Ksanjara Ksanjara reopened this Jan 27, 2021
tomas-light added a commit that referenced this issue Feb 2, 2021
@tomas-light
#244 update buttons config
73e03ea
@tomas-light tomas-light linked a pull request Feb 2, 2021 that will close this issue
#244 update buttons config #285
Merged
AndreiMazol pushed a commit that referenced this issue Feb 2, 2021
@tomas-light
#244 update buttons config (#285)
1b65293
@tomas-light tomas-light linked a pull request Feb 17, 2021 that will close this issue
fix toolbar buttons hiding #332
Merged
@AndreiMazol AndreiMazol removed this from the Standalone Mode milestone Apr 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-light tomas-light

@Ksanjara Ksanjara

Labels
enhancement
Projects
None yet
Milestone
No milestone
3 participants
@tomas-light @AndreiMazol @Ksanjara