Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a warning message about localStorage to templates window. #2441

Closed
KonstantinEpam23 opened this issue Apr 3, 2023 · 1 comment · Fixed by #2459
Closed

Add a warning message about localStorage to templates window. #2441

KonstantinEpam23 opened this issue Apr 3, 2023 · 1 comment · Fixed by #2459
Assignees
@yuleicul
Labels
feature request Priority: High
Milestone
Ketcher 2.10.0-rc.1

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented Apr 3, 2023 •
edited by Nitvex
Loading

Solution
Add a warning message to the template saving dialog explaining that custom templates will be saved in local storage

Additional context
Design:
MicrosoftTeams-image

Acceptance criteria
– Warning message is added
– Inputs ("Molecule name" and "Selected attachment points") have the same width
– Button renamed from "Apply" to "Save"
– "Save" button color is changed from gray to green
– Modal name changed from "Template edit" to "Save to templates".
Note: the same modal is used, when editing template (open Template modal, "Templates" tab, click pencil on any template). Here "Template edit" looks correct and is not supposed to be changed.

#184754723
@KonstantinEpam23 KonstantinEpam23 added this to the Ketcher 2.10.0-rc.1 milestone Apr 3, 2023
@Nitvex Nitvex assigned yuleicul and unassigned Nitvex Apr 6, 2023
@yuleicul
Copy link
Collaborator

yuleicul commented Apr 6, 2023 •
edited
Loading

Acceptance criteria
...
– Button renamed from "Apply" to "Save"
– Modal name changed from "Template edit" to "Save to templates".
...

According to UI design,

  • In Save Modal, button renamed from "Apply" to "Save"; In Edit Modal, button renamed from "Apply" to "Edit"
  • Save Modal name is "Save to Templates"; Edit Modal name is "Template Edit"

yuleicul added a commit that referenced this issue Apr 6, 2023
@yuleicul
#2441 - Add warning message to template modal
162e5ed
@yuleicul yuleicul mentioned this issue Apr 6, 2023
Merged
yuleicul added a commit that referenced this issue Apr 12, 2023
@yuleicul
#2441 - Fix input box width
8f612bd
yuleicul added a commit that referenced this issue Apr 12, 2023
@yuleicul
#2441 - Refactor constants according to review
b9e265e
KonstantinEpam23 pushed a commit that referenced this issue Apr 12, 2023
@yuleicul
#2441 Add a warning message about localStorage to templates window (#…
c3fa228 
…2459)

* #2441 - Add warning message to template modal

* #2441 - Fix input box width

* #2441 - Refactor constants according to review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yuleicul yuleicul

Labels
feature request Priority: High
Projects
None yet
Milestone
Ketcher 2.10.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2441 Add a warning message about localStorage to templates window epam/ketcher
4 participants
@yuleicul @Nitvex @Zhirnoff @KonstantinEpam23