Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rotation Tool: display predefined rotation angles and current angle #2463

Closed
vanoprenko opened this issue Apr 7, 2023 · 2 comments · Fixed by #2574
Closed

Rotation Tool: display predefined rotation angles and current angle #2463

vanoprenko opened this issue Apr 7, 2023 · 2 comments · Fixed by #2574

Comments

@vanoprenko
Copy link
Collaborator

vanoprenko commented Apr 7, 2023

Enhance the rotation tool introduced in scope of #2090, so that user can see predefined rotation angles' marks as well as current rotation angle and can easier rotate the selection on needed angle. The rotation tool should work as follows:

  1. Once user clicks the rotation handle and rotation mode is activated, the rounded rectangle should be replaced with a circle. Center of the circle should be in the center of rotation, circle diameter equal to the height of replaced rectangle. The rotation handle should not change its position while switching from selection to rotation mode and back.
  2. The following predefined angles should be marked on the rotation circle: -90, -60, -45, -30, 0, 30, 45, 60, 90
  3. Once user starts rotating the structure, the set of angles shown should always cover [-90 - +90] range relatively to the handle position, e.g. if the structure is rotated for 60 degrees, user should see -30, 0, 30, 45, 60, 90, 120, 135, 150
  4. Current rotation angle should be displayed at starting position (0 degree).
  5. Once user releases left mouse button, the rotation mode is deactivated and selected fragment stays in its new position (rotated). Rotation circle should be replaced with rounded rectangle (handle on top).

hover-handle

rotation-start

rotation in progress

#184121704

@yuleicul
Copy link
Collaborator

yuleicul commented Apr 26, 2023

  1. Once user starts rotating the structure, the set of angles shown should always cover [-90 - +90] range relatively to the handle position, e.g. if the structure is rotated for 60 degrees, user should see -30, 0, 30, 45, 60, 90, 120, 135, 150

rotation in progress

One question here, according to ''the set of angles shown should always cover [-90 - +90] range relatively to the handle position", angles of the image above should be like

rotation-angles

This looks a bit wierd huh... Which one is correct?

@yuleicul
Copy link
Collaborator

yuleicul commented May 5, 2023

  1. Once user starts rotating the structure, the set of angles shown should always cover [-90 - +90] range relatively to the handle position, e.g. if the structure is rotated for 60 degrees, user should see -30, 0, 30, 45, 60, 90, 120, 135, 150
rotation in progress

One question here, according to ''the set of angles shown should always cover [-90 - +90] range relatively to the handle position", angles of the image above should be like

rotation-angles

This looks a bit wierd huh... Which one is correct?

It should show "nice" degrees between [currentDegree - 90, currentDegree + 90]

yuleicul added a commit that referenced this issue May 11, 2023
KonstantinEpam23 pushed a commit that referenced this issue May 18, 2023
KonstantinEpam23 pushed a commit that referenced this issue May 18, 2023
KonstantinEpam23 pushed a commit that referenced this issue May 18, 2023
KonstantinEpam23 pushed a commit that referenced this issue May 18, 2023
KonstantinEpam23 pushed a commit that referenced this issue May 18, 2023
…ngle (#2574)

* 2463 - Rename bounding rectangle

* #2463 - Draw predefined x30 degrees

* #2463 - Fix protractor to be the most backward

* #2463 - Add current rotate degree and rotate arc

* #2463 - Update unit tests

* #2463 - Fix handle getting stuck when moving fast

* #2463 - Fix rotate arc overlapping structure

* #2463 - Add x45 degrees and hidden degrees out of ±90°

* #2463 - Hide predefined degree text if radius is less than 65

* #2463 - Fix `dragMove` being called without `dragStart` being called first when DnDing very fast

* #2463 - Update unit tests

* #2463 - Fix wheel to show +/-90 degrees on both sides

* #2463 - Fix current mark to be highlighted except for 0

* #2463 - Fix handle line and circle line going out of sync

* #2463 - Fix protractor staying after screenshot/being paused

* #2463 - Fix rotation handle to show when selecting all by ctrl+a

* #2463  - Fix rotation center to be right when scrollbar shows

* #2463 - Add unit tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants