Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When atoms are selected, pressing atoms hotkey opens a modal window instead of an instant replacement #2490

Closed
Zhirnoff opened this issue Apr 18, 2023 · 1 comment · Fixed by #2592
Closed

When atoms are selected, pressing atoms hotkey opens a modal window instead of an instant replacement #2490

Zhirnoff opened this issue Apr 18, 2023 · 1 comment · Fixed by #2592
Assignees
@gairon
Labels
bug
Milestone
Ketcher 2.11.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add few atoms on canvas (e.g. Nitrogen)
  3. Select all atoms with 'Selection tool'
  4. Press 'O' hotkey

Actual behavior
Modal window 'Atom properties' appears.
If in 'Atom properties' modal window we enter atom symbol and click Apply, then this atom appears under the cursor, but it cannot be applied when clicking on canvas.

Expected behavior
Selected atoms are replaces with those assigned to the hotkey.
Selected tool remains active and the atom does not appear under mouse cursor.
Screenshots

2023-04-18_14h46_48.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 109.0.5414.120 (Official Build) (64-bit)

Ketcher version
Version 2.9.0-rc.6
@Zhirnoff Zhirnoff added the bug label Apr 18, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.11.0-rc.1 milestone Apr 18, 2023
@gairon gairon assigned gairon and unassigned Nitvex May 9, 2023
@gairon
Copy link
Contributor

gairon commented May 11, 2023

The problem with "Selected tool remains active and the atom does not appear under mouse cursor." will be done in #2428

gairon added a commit that referenced this issue May 11, 2023
@gairon
#2490 - When atoms are selected, pressing atoms hotkey opens a modal …
5b7c3a7 
…window instead of an instant replacement

* Remove opening Label Editor when pressing hot keys
@gairon gairon linked a pull request May 11, 2023 that will close this issue
#2490 - When atoms are selected, pressing atoms hotkey opens a modal window instead of an instant replacement #2592
Merged
@yuleicul yuleicul mentioned this issue May 12, 2023
Closed
gairon added a commit that referenced this issue May 14, 2023
@gairon
#2490 - When atoms are selected, pressing atoms hotkey opens a modal …
70ec4d2 
…window instead of an instant replacement (#2592)

* Remove opening Label Editor when pressing hot keys
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gairon gairon

Labels
bug
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
3 participants
@gairon @Nitvex @Zhirnoff