Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toolbar arrow is active after the Ketcher with iFrame is loaded and disappears when you click on it #2512

Closed
Zhirnoff opened this issue Apr 21, 2023 · 0 comments · Fixed by #2607
Closed

Toolbar arrow is active after the Ketcher with iFrame is loaded and disappears when you click on it #2512

Zhirnoff opened this issue Apr 21, 2023 · 0 comments · Fixed by #2607
Assignees
@VasilevDO
Labels
Priority: High
Milestone
Ketcher 2.11.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher with iFrame
  2. Set Height to 632
  3. Click 'Open modal'
  4. Look at left toolbar navigation arrow
  5. Click on arrow

Actual behavior
Toolbar arrow is active even though all buttons are placed in the iFrame and there's no need to scroll.
When you click on the arrow, it disappears and there is no way to scroll

Expected behavior
Toolbar arrows not activates because toolbar buttons fit into the iFrame so there's no need to scroll.

Screenshots

2023-04-21_14h51_19.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.10.0-rc.1

#184993424
@Zhirnoff Zhirnoff added this to the Ketcher 2.11.0-rc.1 milestone Apr 21, 2023
@VasilevDO VasilevDO assigned VasilevDO and unassigned Nitvex May 5, 2023
VasilevDO pushed a commit that referenced this issue May 11, 2023
#2512 - toolbar arrows - unnecessary margins removed
edd2dfa
VasilevDO pushed a commit that referenced this issue May 11, 2023
#2512 - visibility threshold is set to 1 for the right and left toolbars
951d5db
VasilevDO pushed a commit that referenced this issue May 15, 2023
#2512 - scroll end ref elements threshold adjusted
1d7af08
@VasilevDO VasilevDO mentioned this issue May 15, 2023
Merged
VasilevDO pushed a commit that referenced this issue May 16, 2023
#2512 - cut unnecessary useInView params
8188f33
Nitvex pushed a commit that referenced this issue May 17, 2023
@VasilevDO
#2512 Toolbar arrow is active after the Ketcher with iFrame is loaded…
191065b 
… and disappears when you click on it (#2607)

* #2512 - toolbar arrows - unnecessary margins removed

* #2512 - visibility threshold is set to 1 for the right and left toolbars

* #2512 - scroll end ref elements threshold adjusted

* 2512 - the toolbar arrow scroll component apprears only when the content length is greater than the view area for that toolbar

* #2512 - cut unnecessary useInView params

---------

Co-authored-by: Dmitrii Vasilev <dmitrii.vasilev@clarivate.com>
flange-ipb added a commit to IUPAC-InChI/InChI-Web-Demo that referenced this issue Jun 28, 2023
@flange-ipb
increase minimum height of Ketcher editor
0a7432e 
(temporarily fixes epam/ketcher#2512 for the right toolbar)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@VasilevDO VasilevDO

Labels
Priority: High
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
3 participants
@Nitvex @Zhirnoff @VasilevDO