Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect rendering of superatom with multiple connection points #2517

Closed
Zhirnoff opened this issue Apr 21, 2023 · 2 comments · Fixed by #2567, #2570 or #2594
Closed

Incorrect rendering of superatom with multiple connection points #2517

Zhirnoff opened this issue Apr 21, 2023 · 2 comments · Fixed by #2567, #2570 or #2594
Assignees
@AnastasiiaPlyako
Labels
regression Issue was found during regression
Milestone
Ketcher 2.11.0-rc.1

Comments

@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Apr 21, 2023 •
edited
Loading

Steps to Reproduce
Scenario 1

  1. Open Ketcher
  2. Add file Superatom.zip on canvas
  3. Look at Superatom
    Fixed in 2.10.0-rc.2

Scenario 2

  1. Open Ketcher
  2. Add file Superatom.zip on canvas
  3. Select 'S-group Tool' and rename Superatom
    Will be fixed in 2.11.0-rc.1

Actual behavior
Part of the structure disappears
2023-04-21_18h19_53

Expected behavior
File opens with Superaton name and brackets
2023-04-21_18h19_38

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.10.0-rc.1

Test case
[EPMLSOPKET-[12599]
@Zhirnoff Zhirnoff added bug regression Issue was found during regression labels Apr 21, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.10.0-rc.2 milestone Apr 21, 2023
@KonstantinEpam23
Copy link
Collaborator

Wll be resolved by prohibiting contracting Superatoms w/ more than one attachment point

AnastasiiaPlyako added a commit that referenced this issue May 2, 2023
@AnastasiiaPlyako
#2517 fix bug with disappearing part of structure
be7f781
@Nitvex Nitvex linked a pull request May 2, 2023 that will close this issue
Backmerge: #2517 File with Superatom opens without part of structure #2567
Merged
AnastasiiaPlyako added a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
#2517 fix bug with disappearing part of structure
d9eec2a
@Nitvex Nitvex linked a pull request May 3, 2023 that will close this issue
#2517 File with Superatom opens without part of structure #2570
Merged
AnastasiiaPlyako added a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
#2517 move expand logic outside "fromPaste"
4db6378
AnastasiiaPlyako added a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
#2517 move expand logic outside "fromPaste"
0a438bd
AnastasiiaPlyako added a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
#2517 fix comment
3240e72
AnastasiiaPlyako added a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
#2517 fix comment
355bcd2
KonstantinEpam23 pushed a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
#2517 File with Superatom opens without part of structure (#2570)
81ace02 
* #2517 fix bug with disappearing part of structure

* #2517 move expand logic outside "fromPaste"

* #2517 fix comment
KonstantinEpam23 pushed a commit that referenced this issue May 3, 2023
@AnastasiiaPlyako
Backmerge: #2517 File with Superatom opens without part of structure (#…
1a90da3 
…2567)

* #2517 fix bug with disappearing part of structure

* #2517 move expand logic outside "fromPaste"

* #2517 fix comment
@Nitvex
Copy link
Collaborator

Nitvex commented May 11, 2023

Bug is reopened due to the case, when a user renames pasted Superatom.

@Nitvex Nitvex reopened this May 11, 2023
@KonstantinEpam23 KonstantinEpam23 changed the title File with Superatom opens without part of structure Incorrect rendering of superatom with multiple connection points May 11, 2023
AnastasiiaPlyako added a commit that referenced this issue May 11, 2023
@AnastasiiaPlyako
#2517 Incorrect rendering of superatom with multiple connection points
656fca4
@yuleicul yuleicul linked a pull request May 12, 2023 that will close this issue
#2517 Incorrect rendering of superatom with multiple connection points #2594
Merged
KonstantinEpam23 pushed a commit that referenced this issue May 17, 2023
@AnastasiiaPlyako
#2517 Incorrect rendering of superatom with multiple connection points (
189c5ab 
#2594)
@Zhirnoff Zhirnoff mentioned this issue Jun 28, 2023
Closed
@ilya-asiyuk-epam ilya-asiyuk-epam mentioned this issue May 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AnastasiiaPlyako AnastasiiaPlyako

Labels
regression Issue was found during regression
Projects
None yet
Milestone
Ketcher 2.11.0-rc.1
4 participants
@Nitvex @Zhirnoff @AnastasiiaPlyako @KonstantinEpam23