Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Erase tool does not completely remove the Functional Groups if it selecting via the hot key CTRL + A #2528

Closed
Zhirnoff opened this issue Apr 25, 2023 · 0 comments · Fixed by #2536 or #2542
Closed

Erase tool does not completely remove the Functional Groups if it selecting via the hot key CTRL + A #2528

Zhirnoff opened this issue Apr 25, 2023 · 0 comments · Fixed by #2536 or #2542
Assignees
@Nitvex
Labels
bug regression Issue was found during regression
Milestone
Ketcher 2.10.0-rc.2

Comments

@Zhirnoff
Copy link
Collaborator

Steps to Reproduce

  1. Open Ketcher
  2. Add several FG on the canvas
  3. Expand two FGs
  4. Press CTRL+A for select all FGs
  5. Press hotkey DEL or Erase tool on the left toolbar

Actual behavior
Functional Groups disappear, but brackets from expanded FGs remain and highlights from contracted ones. You can also hover over the highlight or brackets and collapse or expand the disappeared FG. When this occurs, errors appear in the developer console.

Expected behavior
FGs deleted from canvas.

Screenshots

2023-04-25_16h28_04.mp4

Desktop (please complete the following information):

  • OS: Windows 10
  • Browser Chrome
  • Version 112.0.5615.138 (Official Build) (64-bit)

Ketcher version
Version 2.10.0-rc.1

Test case
EPMLSOPKET-11950
@Zhirnoff Zhirnoff added bug regression Issue was found during regression labels Apr 25, 2023
@Zhirnoff Zhirnoff added this to the Ketcher 2.10.0-rc.2 milestone Apr 25, 2023
@Nitvex Nitvex self-assigned this Apr 26, 2023
Nitvex added a commit that referenced this issue Apr 26, 2023
@Nitvex
#2528 – Erase tool does not completely remove the Functional Groups i…
4705a15 
…f it selecting via the hot key CTRL + A
@Nitvex Nitvex mentioned this issue Apr 26, 2023
Merged
@Nitvex Nitvex linked a pull request Apr 26, 2023 that will close this issue
#2528 – Erase tool does not completely remove the Functional Groups if it selecting via the hot key CTRL + A #2536
Merged
Nitvex added a commit that referenced this issue Apr 27, 2023
@Nitvex
#2528 – Erase tool does not completely remove the Functional Groups i…
9936d0a 
…f it selecting via the hot key CTRL + A (#2536)
Nitvex added a commit that referenced this issue Apr 27, 2023
@Nitvex
Backmerge: #2528 – Erase tool does not completely remove the Function…
1f23da5 
…al Groups if it selecting via the hot key CTRL + A (#2536)
@Nitvex Nitvex mentioned this issue Apr 27, 2023
Merged
Nitvex added a commit that referenced this issue Apr 27, 2023
@Nitvex
Backmerge: #2528 – Erase tool does not completely remove the Function…
4b41b64 
…al Groups if it selecting via the hot key CTRL + A (#2536) (#2542)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
bug regression Issue was found during regression
Projects
None yet
Milestone
Ketcher 2.10.0-rc.2
2 participants
@Nitvex @Zhirnoff