Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Draw selection outline correctly for hovered structures #2595

Closed
KonstantinEpam23 opened this issue May 11, 2023 · 2 comments · Fixed by #2929
Closed

Draw selection outline correctly for hovered structures #2595

KonstantinEpam23 opened this issue May 11, 2023 · 2 comments · Fixed by #2929
Assignees
@Iogsotot
Labels
feature request
Milestone
Ketcher 2.14.0-rc.1

Comments

@KonstantinEpam23
Copy link
Collaborator

KonstantinEpam23 commented May 11, 2023 •
edited
Loading

Actual behaviour
After introducing the new selection in #2088 if the structure is in an expanded s-group or is selected with the "fragment selection" tool and is hovered over - the bond selections will be drawn over atoms.
Screenshot 2023-05-12 at 06 49 36
Screenshot 2023-05-12 at 06 49 56

Expected behaviour
Atoms should always be drawn above the bonds and the bond contours should not intersect atom contours.
@KonstantinEpam23 KonstantinEpam23 self-assigned this May 12, 2023
@KonstantinEpam23 KonstantinEpam23 added this to the Refined Backlog milestone May 12, 2023
@KonstantinEpam23 KonstantinEpam23 changed the title Draw selection outlinecorrectly for hovered structures Draw selection outline correctly for hovered structures May 12, 2023
@Nitvex Nitvex assigned Nitvex and unassigned KonstantinEpam23 Jun 15, 2023
@Iogsotot Iogsotot self-assigned this Jul 5, 2023
Iogsotot added a commit that referenced this issue Jul 10, 2023
@Iogsotot
#2595 - feat: add a layer for the atom so that it is drawn over the b…
c3e917c 
…onds (hovering)
Iogsotot added a commit that referenced this issue Jul 10, 2023
@Iogsotot
#2595 - docs: update LayerMap
f710b5c
Iogsotot added a commit that referenced this issue Jul 10, 2023
@Iogsotot
#2595 - feat: add a layer for bondSkeleton
9edc2fc
@Nitvex Nitvex removed their assignment Jul 10, 2023
@nightnick
Copy link
Collaborator

Please update the current behavior so that atom outline would not overlap the whole bond, but only its outline.
Ideally we want one united outline, without intersection within it. Maybe in next phase?
image

@Iogsotot Iogsotot mentioned this issue Jul 18, 2023
Merged
8 tasks
Nitvex added a commit that referenced this issue Aug 1, 2023
@Nitvex
#2595 – updated screenshots and golden files
ddc294f
Nitvex added a commit that referenced this issue Aug 1, 2023
@Nitvex
#2595 – updated screenshots and golden files
abdf04f
Nitvex added a commit that referenced this issue Aug 1, 2023
@Nitvex
#2595 – updated screenshots
0ab646d
Nitvex added a commit that referenced this issue Aug 1, 2023
@Iogsotot @Nitvex
#2595 draw selection outline correctly for hovered structures (#2929)
713e8c6 
* 2595 - feat: add a layer for the atom so that it is drawn over the bonds (hovering)

* 2595 - docs: update LayerMap

* 2595 - feat: add e2e test for structure selection outline, update screenshots

* 2916 - fix: e2e tests for ZoomIn/ZoomOut and update screenshots

* refactor: add link for issue in e2e test, fix code style

* #2595 – updated screenshots and golden files

* #2595 – updated screenshots

---------

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
@y-holik
Copy link
Collaborator

y-holik commented Aug 10, 2023

test cases are created

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Iogsotot Iogsotot

Labels
feature request
Projects
None yet
Milestone
Ketcher 2.14.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2595 draw selection outline correctly for hovered structures epam/ketcher
5 participants
@nightnick @Nitvex @Iogsotot @KonstantinEpam23 @y-holik