Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring request: remove duplicate shared utils functions #2642

Closed
1 of 2 tasks
kaluginserg opened this issue May 22, 2023 · 0 comments · Fixed by #3007
Closed
1 of 2 tasks

Refactoring request: remove duplicate shared utils functions #2642

kaluginserg opened this issue May 22, 2023 · 0 comments · Fixed by #3007
Assignees
@kaluginserg
Labels
technical debt

Comments

@kaluginserg
Copy link
Collaborator

kaluginserg commented May 22, 2023 •
edited
Loading

Currently, we have similar shared files with utilities: utils.js/ts and closest.js/ts located at:

  • /packages/ketcher-react/src/script/editor/shared/**
  • /packages/ketcher-core/src/application/editor/shared/**

They have the same functions, the same name, and mostly the same implementation.

TODO:

  • check the usage of these files and keep only one utils.js/ts and closest.js/ts with the newest implementations.
  • Move these utilities to /packages/ketcher-core/src/utilities
  • Rewrite ketcher-core and ketcher-react to use these utilities from ketcher-core

Steps:
@gairon gairon changed the title Refactoring request: remove duplicate shared utils functins Refactoring request: remove duplicate shared utils functions May 23, 2023
@gairon gairon linked a pull request May 23, 2023 that will close this issue
#1905 - Refactor Render class: convert raphaelRender.js to TypeScript and add necessary types #2646
Merged
@gairon gairon assigned gairon and unassigned Nitvex and gairon May 23, 2023
@gairon gairon removed a link to a pull request May 23, 2023
#1905 - Refactor Render class: convert raphaelRender.js to TypeScript and add necessary types #2646
Merged
@kaluginserg kaluginserg self-assigned this Jul 31, 2023
kaluginserg added a commit that referenced this issue Jul 31, 2023
@kaluginserg
#2642 - remove duplicates from shared/utils from ketcher-core and ket…
5d470f8 
…cher-react, wrap reused utils to the vectorUtils
@kaluginserg kaluginserg linked a pull request Jul 31, 2023 that will close this issue
#2642 - Refactoring request: remove duplicate shared utils functions #3007
Merged
8 tasks
@kaluginserg kaluginserg mentioned this issue Jul 31, 2023
Merged
8 tasks
Nitvex added a commit that referenced this issue Aug 9, 2023
@kaluginserg @Nitvex
#2642 - remove duplicates from shared/utils from ketcher-core and ket…
6856ccb 
…cher-react, wrap reused utils to the vectorUtils (#3007)

Co-authored-by: Nikita_Vozisov <Nikita_Vozisov@epam.com>
@github-project-automation github-project-automation bot moved this to Done in Ketcher Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kaluginserg kaluginserg

Labels
technical debt
Projects
Ketcher
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#2642 - Refactoring request: remove duplicate shared utils functions epam/ketcher
3 participants
@gairon @kaluginserg @Nitvex