Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

S-Group brackets place in incorrect place on structure with double bonds and sprouted single bonds #269

Closed
Ksanjara opened this issue Jan 27, 2021 · 0 comments · Fixed by #358
Assignees
Labels

Comments

@Ksanjara
Copy link

Affected Version: Remote, Standalone
Steps to Reproduce:

  1. Create a chain structure and add double bonds through one bond.
  2. Sprout single bonds from every carbon atom in chain structure.
  3. Click 'S-Group Tool' button.
  4. Create Generic S-Group with part of structure include double bond.

Expected Result:
Correct Generic Group is created, brackets place correctly across selected part of structure.

Actual Result:
Brackets place in incorrect place when it is a part of structure or single atom with all available connections.
2021-01-27_14h56_29

@Ksanjara Ksanjara added the bug label Jan 27, 2021
@ensemenova ensemenova self-assigned this Feb 26, 2021
ensemenova added a commit that referenced this issue Mar 2, 2021
ensemenova added a commit that referenced this issue Mar 2, 2021
ensemenova added a commit that referenced this issue Mar 2, 2021
AndreiMazol pushed a commit that referenced this issue Mar 3, 2021
…on (#358)

* refactor and rename

* fix review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants