-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lookup abbreviations using the keyboard #2731
Comments
gairon
added a commit
that referenced
this issue
Jun 6, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 6, 2023
* Add possibility to search abbreviations without opening the Templates dialog
Found duplicated abbreviations (numbers are count of instances):
|
gairon
added a commit
that referenced
this issue
Jun 7, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
…iations-using-the-keyboard # Conflicts: # packages/ketcher-react/src/script/ui/state/hotkeys.ts
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 13, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 15, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
Screen.Recording.2023-06-15.at.11.52.18-1.mov |
gairon
added a commit
that referenced
this issue
Jun 15, 2023
…iations-using-the-keyboard # Conflicts: # packages/ketcher-react/src/script/ui/state/hotkeys.ts
gairon
added a commit
that referenced
this issue
Jun 15, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 15, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 19, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 19, 2023
…iations-using-the-keyboard # Conflicts: # packages/ketcher-react/jest.config.js # packages/ketcher-react/src/script/ui/views/components/Dialog/Dialog.tsx
gairon
added a commit
that referenced
this issue
Jun 19, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 20, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 20, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 20, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 20, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
gairon
added a commit
that referenced
this issue
Jun 21, 2023
* Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
Nitvex
pushed a commit
that referenced
this issue
Jun 22, 2023
* #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog * #2731 - Lookup abbreviations using the keyboard * Add possibility to search abbreviations from Templates, Functional Groups, Salt and Solvents and Elements without opening the Templates dialog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
From the main canvas, provide a way for the user to quickly lookup abbreviations (templates, functional groups, etc.) via typing their names.
Solution
When a user is in the main editor view and starts typing the name of the abbreviation on the keyboard - a context window should appear containing current user input and a list of matching abbreviations in a form of a drop-down list that can be navigated via the keyboard.
When a user presses the "Enter" key - the context window closes and the selected abbreviation is set as the current template that the user can place on the canvas.
There may be collisions of abbreviation names and current Ketcher keyboard shortcuts, so the context menu should only appear if more than one letter was typed within a certain time limit (e.g. appear if the user typed the second letter within 1000 ms)
DCM (dichloromethane)
CO2Me
Element (Name)
, F.e.Br (Bromine)
.No matching results
.Start typing atom or template structure name
without any options.The suggestions list should be sorted according to these criteria:
mer
and optionHg (Mercury)
similarity will be3/7
by matching with the element name. For the lookup valuehg
and optionHg (Mercury)
will be 1 by matching the element abbreviation. If the lookup value is found in the name and the abbreviation, then the highest value of similarity should be taken for this option. If 2 items are equal by this criteria, then check criteria 3Hg (Mercury)
#184100484
The text was updated successfully, but these errors were encountered: