Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix memory leak for Ketcher when it is opened inside modal #2912

Closed
Nitvex opened this issue Jul 11, 2023 · 2 comments · Fixed by #3027
Closed

Fix memory leak for Ketcher when it is opened inside modal #2912

Nitvex opened this issue Jul 11, 2023 · 2 comments · Fixed by #3027
Assignees
@StarlaStarla
Labels
bug
Milestone
Ketcher 2.14.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Jul 11, 2023

Steps to Reproduce

  1. Open Ketcher inside modal
  2. Close the modal
  3. Open Ketcher again
  4. Repeat steps 1-3 multiple times

Actual behavior
User receives memory leak warning:
MicrosoftTeams-image (41)

Expected behavior
Memory leak is eliminated. No warning message is shown.
@Nitvex Nitvex added the bug label Jul 11, 2023
@Nitvex Nitvex added this to the Ketcher 2.13.0-rc.1 milestone Jul 11, 2023
@Nitvex Nitvex self-assigned this Jul 11, 2023
@Nitvex Nitvex changed the title Fix memory leak for Ketcher, when it is opened inside modal Fix memory leak for Ketcher when it is opened inside modal Jul 11, 2023
@Nitvex Nitvex assigned StarlaStarla and unassigned Nitvex Jul 19, 2023
StarlaStarla added a commit that referenced this issue Aug 3, 2023
@StarlaStarla
#2912 Fix memory leak for Ketcher when it is opened inside modal
88e94e6
StarlaStarla added a commit that referenced this issue Aug 3, 2023
@StarlaStarla
#2912 refactor the root name
ed5b2b3
@StarlaStarla StarlaStarla linked a pull request Aug 3, 2023 that will close this issue
#2912 - fix memory leak for ketcher when it is opened inside modal #3027
Merged
8 tasks
StarlaStarla added a commit that referenced this issue Aug 4, 2023
@StarlaStarla
#2912 fix EditorProps properties issue
2282c06
StarlaStarla added a commit that referenced this issue Aug 7, 2023
@StarlaStarla
#2912 fix react warnning
f9027b1
StarlaStarla added a commit that referenced this issue Aug 7, 2023
@StarlaStarla
#2912 fix inconsistent methods
4cd9541
StarlaStarla added a commit that referenced this issue Aug 7, 2023
@StarlaStarla
#2912 modal example to reproduce memory leak issue
5e1b5ed
StarlaStarla added a commit that referenced this issue Aug 8, 2023
@StarlaStarla
#2912 reproduce bug
bfb8ed7
Nitvex pushed a commit that referenced this issue Aug 9, 2023
@StarlaStarla @Nitvex
#2912 reproduce bug
d669bfb
Nitvex pushed a commit that referenced this issue Aug 9, 2023
@StarlaStarla @Nitvex
#2912 modal example to reproduce memory leak issue
e34720a
Zhirnoff added a commit that referenced this issue Aug 9, 2023
@Zhirnoff
Merge pull request #3027 from epam/2912-fix-memory-leak-for-ketcher-w…
48d89cd 
…hen-it-is-opened-inside-modal

#2912 - fix memory leak for ketcher when it is opened inside modal
@StarlaStarla StarlaStarla mentioned this issue Feb 2, 2024
Closed
9 tasks
@hellhorse123
Copy link

I still get error:
MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 layout listeners added. Use emitter.setMaxListeners() to increase limit
when open/close modal with ketcher at many times

@rrodionov91
Copy link
Collaborator

Hi @hellhorse123
Thank you for notifying us. We will check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@StarlaStarla StarlaStarla

Labels
bug
Projects
None yet
Milestone
Ketcher 2.14.0-rc.1
4 participants
@rrodionov91 @StarlaStarla @Nitvex @hellhorse123