Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incorrect order of Hydrogen symbol in abbreviation of the atoms when adding them to the structure #2957

Closed
Ustianskii opened this issue Jul 25, 2023 · 1 comment · Fixed by #2992
Closed

Incorrect order of Hydrogen symbol in abbreviation of the atoms when adding them to the structure #2957

Ustianskii opened this issue Jul 25, 2023 · 1 comment · Fixed by #2992
Assignees
@nanoblit
Milestone
Ketcher 2.14.0-rc.1

Comments

@Ustianskii
Copy link
Collaborator

Ustianskii commented Jul 25, 2023 •
edited
Loading

Steps to Reproduce

  1. Launch "Ketcher"
  2. Create any Chain structure
  3. With Shift key select some atoms in the structure and click the "Phosphorus (P)" button on the Atom Palette bar.

Expected behaviour
Following abbreviation of atoms should be present in the Chain structure
"H2P" for the first atom of the structure
"PH2" for the last atom of the structure"
"PH" for all other atoms.

Actual behaviour
image

Ketcher version [e.g. v2.4.2].
Version 2.13.0-rc.1
@Ustianskii Ustianskii added the bug label Jul 25, 2023
@Ustianskii Ustianskii added this to the Ketcher 2.13.0-rc.2 milestone Jul 25, 2023
@nanoblit nanoblit assigned nanoblit and unassigned Nitvex Jul 27, 2023
nanoblit added a commit that referenced this issue Jul 28, 2023
@nanoblit
#2957 - make hydrogens in the middle of a chain appear on the right side
8cf044c
@nanoblit nanoblit linked a pull request Jul 28, 2023 that will close this issue
#2957 - Incorrect order of Hydrogen symbol in abbreviation of the atoms when adding them to the structure #2992
Merged
8 tasks
nanoblit added a commit that referenced this issue Jul 28, 2023
@nanoblit
#2957 - remove unnecessary helper file
5620124
nanoblit added a commit that referenced this issue Jul 28, 2023
@nanoblit
#2957 - change pos to position
008e203
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - make hydrogens in the middle of a chain appear on the right side
1e4cce1
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - remove unnecessary helper file
4f732e4
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - change pos to position
ba74a10
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - Fix act error in a test
3911890
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - make hydrogens in the middle of a chain appear on the right side
c697fe3
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - remove unnecessary helper file
9d68a49
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - change pos to position
40a7e4d
nanoblit added a commit that referenced this issue Aug 7, 2023
@nanoblit
#2957 - Fix act error in a test
cb6ab5a
nanoblit added a commit that referenced this issue Aug 8, 2023
@nanoblit
#2957 - Update snapshots
11692a7
nanoblit added a commit that referenced this issue Aug 8, 2023
@nanoblit
#2957 - Update snapshot
8254ffd
Nitvex pushed a commit that referenced this issue Aug 8, 2023
@nanoblit
#2957 - Incorrect order of Hydrogen symbol in abbreviation of the ato…
b77f8f0 
…ms when adding them to the structure (#2992)

* #2957 - make hydrogens in the middle of a chain appear on the right side

* #2957 - remove unnecessary helper file

* #2957 - change pos to position

* #2957 - make hydrogens in the middle of a chain appear on the right side

* #2957 - remove unnecessary helper file

* #2957 - change pos to position

* #2957 - Fix act error in a test

* #2957 - Update snapshots

* #2957 - Update snapshot
@AleksandraSmolianinova
Copy link
Collaborator

Test cases are being created.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanoblit nanoblit

Labels
None yet
Projects
None yet
Milestone
Ketcher 2.14.0-rc.1
4 participants
@nanoblit @Nitvex @Ustianskii @AleksandraSmolianinova