Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore abbreviation lookup for repetitive keystrokes #2982

Closed
Nitvex opened this issue Jul 27, 2023 · 2 comments · Fixed by #3021
Closed

Ignore abbreviation lookup for repetitive keystrokes #2982

Nitvex opened this issue Jul 27, 2023 · 2 comments · Fixed by #3021
Assignees
@Nitvex
Labels
feature request Priority: High
Milestone
Ketcher 2.14.0-rc.1

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Jul 27, 2023 •
edited by Zhirnoff
Loading

Background
Abbreviation lookup is shown, when user tries to change currently active tool from a group. This happens, for example, for bond tool – you press "1" and want to change bond type, but this actually causes abbreviation lookup to appear.

Solution
Do not show abbreviation lookup for repetitive keys, which are assigned as shortcuts.

Additional context
Knows issues:
– Bond tool
– Template tool, when changing Benzene ring -> Cyclopentadiene -> Cyclohexane

#185678973
@Nitvex Nitvex added this to the Ketcher 2.14.0-rc.1 milestone Jul 27, 2023
@Nitvex Nitvex self-assigned this Jul 27, 2023
Nitvex added a commit that referenced this issue Aug 1, 2023
@Nitvex
#2982 – Ignore abbreviation lookup for repetitive keystrokes
ad55698
Nitvex added a commit that referenced this issue Aug 1, 2023
@Nitvex
#2982 – added tests for not showing abbreviation lookup for repetitiv…
8e59995 
…e keystrokes
@Nitvex Nitvex mentioned this issue Aug 2, 2023
Merged
8 tasks
Nitvex added a commit that referenced this issue Aug 2, 2023
@Nitvex
#2982 – fixed failing test
5854f14
Nitvex added a commit that referenced this issue Aug 2, 2023
@Nitvex
#2982 – fixed failing test
fd653df
Nitvex added a commit that referenced this issue Aug 2, 2023
@Nitvex
#2982 – fixed failing test
7a35cf3
Nitvex added a commit that referenced this issue Aug 2, 2023
@Nitvex
#2982 ignore abbreviation lookup for repetitive keystrokes (#3021)
760ba42 
* #2982 – Ignore abbreviation lookup for repetitive keystrokes

* #2982 – added tests for not showing abbreviation lookup for repetitive keystrokes

* #2982 – fixed failing test
@Zhirnoff
Copy link
Collaborator

Zhirnoff commented Aug 9, 2023

Manual test cases will be written by me

@ViktoriaTkacheva
Copy link
Collaborator

When pressing shortcut 0 several times, the Abbreviation lookup appears (it is inconsistent with a similar case for 3 and 4 shortcuts where the Abbreviation lookup does not show up)
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
feature request Priority: High
Projects
None yet
Milestone
Ketcher 2.14.0-rc.1
Development

Successfully merging a pull request may close this issue.

#2982 ignore abbreviation lookup for repetitive keystrokes epam/ketcher
3 participants
@Nitvex @Zhirnoff @ViktoriaTkacheva