Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide additional logging #3040

Closed
Nitvex opened this issue Aug 4, 2023 · 1 comment · Fixed by #3375
Closed

Provide additional logging #3040

Nitvex opened this issue Aug 4, 2023 · 1 comment · Fixed by #3375

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Aug 4, 2023

Background
At the moment, Ketcher has a lot of try/catch blocks which catch errors (for example, when parsing files) and show appearing errors in modal. This errors sometimes neither informative for end-user nor developers.

Solution

  1. It is required to add console.error to catch block in order to easy find the places, where error appeared
  2. It is required to prevent non-informative errors to be shown to users (Example error: "cannot read property null of undefined")
@Nitvex Nitvex added this to the Refined Backlog milestone Aug 4, 2023
@Nitvex Nitvex self-assigned this Aug 4, 2023
@Nitvex Nitvex changed the title Add logs for caught errors Provide informative errors for users and developers Aug 4, 2023
@nanoblit nanoblit assigned nanoblit and unassigned Nitvex Sep 26, 2023
nanoblit added a commit that referenced this issue Sep 29, 2023
@nanoblit nanoblit linked a pull request Sep 29, 2023 that will close this issue
9 tasks
nanoblit added a commit that referenced this issue Sep 29, 2023
nanoblit added a commit that referenced this issue Sep 29, 2023
@Nitvex Nitvex changed the title Provide informative errors for users and developers Provide additional logging Sep 29, 2023
nanoblit added a commit that referenced this issue Sep 29, 2023
Nitvex pushed a commit that referenced this issue Sep 29, 2023
* #3040 - Add KetcherLogger

* #3040 - Add default logInfo

* #3040 - Raname variables and add default logging settings

* #3040 - Rename variables

* #3040 - Apply suggestions from reviews
AnastasiyaPiatrovaKlu pushed a commit that referenced this issue Oct 2, 2023
* #3040 - Add KetcherLogger

* #3040 - Add default logInfo

* #3040 - Raname variables and add default logging settings

* #3040 - Rename variables

* #3040 - Apply suggestions from reviews
@Zhirnoff
Copy link
Collaborator

Not tested by QA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants