Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply auto zoom and centering for API #3097

Closed
Nitvex opened this issue Aug 14, 2023 · 0 comments · Fixed by #3111 or #3113
Closed

Apply auto zoom and centering for API #3097

Nitvex opened this issue Aug 14, 2023 · 0 comments · Fixed by #3111 or #3113
Assignees
@Nitvex
Labels
feature request Priority: High
Milestone
Ketcher 2.13.0-rc.4

Comments

@Nitvex
Copy link
Collaborator

Nitvex commented Aug 14, 2023

Background
At the moment, centering molecule (#2078) is only working after pressing 'layout' button.
In addition, auto zoom (#2128) is only applied when pasting structure.

Solution
These two behaviours need to be applied when molecules are pasted via ketcher.setMolecule API method
@Nitvex Nitvex added this to the Ketcher 2.13.0-rc.4 milestone Aug 14, 2023
@Nitvex Nitvex self-assigned this Aug 14, 2023
@Nitvex Nitvex changed the title Apply auto zoom and layout for ketcher.setMolecule Apply auto zoom and centering for API Aug 14, 2023
Nitvex added a commit that referenced this issue Aug 14, 2023
@Nitvex
#3097 – Apply auto zoom and centering for API
45e2dc6
@Nitvex Nitvex linked a pull request Aug 14, 2023 that will close this issue
#3097 – apply auto zoom and centering for api #3111
Merged
8 tasks
Nitvex added a commit that referenced this issue Aug 14, 2023
@Nitvex @Zhirnoff
#3097 – apply auto zoom and centering for api (#3111)
480d64d 
* #3097 – Apply auto zoom and centering for API

* - updated snapshots

* - updated expected files;
- updated 2 snapshots

---------

Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
Nitvex added a commit that referenced this issue Aug 14, 2023
@Nitvex @Zhirnoff
* #3097 – Apply auto zoom and centering for API
59dece7 
* - updated snapshots

* - updated expected files;
- updated 2 snapshots

---------

Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
@Nitvex Nitvex linked a pull request Aug 14, 2023 that will close this issue
Backmerge: #3097 – Apply auto zoom and centering for API #3112
Closed
8 tasks
Nitvex added a commit that referenced this issue Aug 14, 2023
@Nitvex
Backmerge: #3097 – Apply auto zoom and centering for API
fc229dd
@Nitvex Nitvex linked a pull request Aug 14, 2023 that will close this issue
Backmerge: #3097 – Apply auto zoom and centering for API #3113
Merged
8 tasks
Nitvex added a commit that referenced this issue Aug 15, 2023
@Nitvex @Zhirnoff
Backmerge: #3097 – Apply auto zoom and centering for API (#3113)
4abc152 
* Backmerge: #3097 – Apply auto zoom and centering for API

* - updated expected snapshots;
- updated test files

---------

Co-authored-by: Mikhail Zhirnov <mikhail_zhirnov@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nitvex Nitvex

Labels
feature request Priority: High
Projects
None yet
Milestone
Ketcher 2.13.0-rc.4
1 participant
@Nitvex