Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error after Undo/Redo actions when User has edited S-Group #311

Closed
Ksanjara opened this issue Feb 10, 2021 · 1 comment · Fixed by #331
Closed

Error after Undo/Redo actions when User has edited S-Group #311

Ksanjara opened this issue Feb 10, 2021 · 1 comment · Fixed by #331
Assignees
@tomas-light @Ksanjara
Labels
bug Priority: High

Comments

@Ksanjara
Copy link

Affected Version: Remote, Standalone
Steps to Reproduce:

  1. Launch Ketcher.
  2. Create chain structure.
  3. Create, for example, Generic S-Group.
  4. Change Generic S-Group to Multiple/SRU-polymer S-Group.
  5. Click 'Undo' button.
  6. Click 'Redo' button.

Expected Result:
User can undo/redo all actions with S-Groups. Undo/Redo works correctly for each step.

Actual Result:
After Undo action part of Structure with S-Group disappears from canvas. When User clicks 'Redo' - part of structure appears without S-Group brackets.
2021-02-10_10h43_31
@AndreiMazol AndreiMazol self-assigned this Feb 10, 2021
tomas-light added a commit that referenced this issue Feb 17, 2021
@tomas-light
#311 improve operation imports
33f7eb6
tomas-light added a commit that referenced this issue Feb 17, 2021
@tomas-light
#311 convert classes syntax to es6, separate operations to files
69a8c11
tomas-light added a commit that referenced this issue Feb 17, 2021
@tomas-light
#311 bugfix undo operation applying for Multiple/SRU-polymer
0f5ae3d
@tomas-light tomas-light linked a pull request Feb 17, 2021 that will close this issue
#311 sgroup invert bugfix #331
Merged
tomas-light added a commit that referenced this issue Feb 17, 2021
@tomas-light
#311 update copyrights
75d9332
tomas-light added a commit that referenced this issue Feb 17, 2021
@tomas-light
#311 fix using of parent and children in SGroupAddToHierarchy, revert…
aef8c61 
… unnecessary changes in sgforest
tomas-light added a commit that referenced this issue Feb 17, 2021
@tomas-light
#311 sgroup invert bugfix (#331)
3b6fc6d 
* #311 improve operation imports

* #311 convert classes syntax to es6, separate operations to files

* #311 bugfix undo operation applying for Multiple/SRU-polymer
@Ksanjara
Copy link
Author

Issue is closed as fixed.

tomas-light added a commit that referenced this issue Feb 19, 2021
@tomas-light
#311 hotfix AtomDelete and BondDelete properties access
9605d6f
tomas-light added a commit that referenced this issue Feb 19, 2021
@tomas-light
#311 hotfix AtomDelete and BondDelete properties access (#337)
cfcdb83
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-light tomas-light

@Ksanjara Ksanjara

Labels
bug Priority: High
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#311 sgroup invert bugfix epam/ketcher
4 participants
@tomas-light @AndreiMazol @Ksanjara @ensemenova