Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Macro: Overlapping of bonds between 2 monomers #3385

Closed
isidoraotasevic opened this issue Oct 2, 2023 · 0 comments · Fixed by #3453
Closed

Macro: Overlapping of bonds between 2 monomers #3385

isidoraotasevic opened this issue Oct 2, 2023 · 0 comments · Fixed by #3453
Assignees
@chgayane
Labels
bug Macromolecules
Milestone
Macromolecules Mi...

Comments

@isidoraotasevic
Copy link
Collaborator

isidoraotasevic commented Oct 2, 2023 •
edited
Loading

Current behavior
User connects R2 of the first monomer with R1 of the second monomer. Then, user connects R1 of the first monomer to R2 of the second monomer = bonds overlap.

Expected behavior

  • The system shall unable user to create more than 1 bond between the first and the second monomer (for example, connecting R2 to R1 AND R1 to R2).
    Screenshots
Capture5555
@Nitvex Nitvex changed the title Overlapping of bonds between 2 monomers [Macro]: Overlapping of bonds between 2 monomers Oct 13, 2023
@Nitvex Nitvex changed the title [Macro]: Overlapping of bonds between 2 monomers Macro: Overlapping of bonds between 2 monomers Oct 13, 2023
chgayane pushed a commit that referenced this issue Oct 17, 2023
#3385 - preventing duplicate bonds between first and second monomer
566985a
@chgayane chgayane linked a pull request Oct 17, 2023 that will close this issue
Macro: #3385 - Overlapping of bonds between 2 monomers #3453
Merged
9 tasks
chgayane pushed a commit that referenced this issue Oct 17, 2023
#3385 - reducing npm vulnerabilities
c170a6d
chgayane pushed a commit that referenced this issue Oct 17, 2023
#3385 - reducing npm vulnerabilities
5837b12
chgayane pushed a commit that referenced this issue Oct 17, 2023
#3385 - updating stylelint rules
2507b05
chgayane pushed a commit that referenced this issue Oct 18, 2023
#3385 - Simplified bond check and e2e test
9e5ef8e
chgayane pushed a commit that referenced this issue Oct 18, 2023
#3385 - adding test for single bond
1ccf13b
Nitvex pushed a commit that referenced this issue Oct 18, 2023
@chgayane
Macro: #3385 - Overlapping of bonds between 2 monomers (#3453)
b8865be 
* #3385 - preventing duplicate bonds between first and second monomer

* #3385 - reducing npm vulnerabilities

* #3385 - reducing npm vulnerabilities

* #3385 - updating stylelint rules

* #3385 - Simplified bond check and e2e test

* #3385 - adding test for single bond

---------

Co-authored-by: Gayane Chilingaryan <gayane_chilingaryan@epam.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@chgayane chgayane

Labels
bug Macromolecules
Projects
None yet
Milestone
Macromolecules Milestone 1
Development

Successfully merging a pull request may close this issue.

Macro: #3385 - Overlapping of bonds between 2 monomers epam/ketcher
4 participants
@Nitvex @Zhirnoff @chgayane @isidoraotasevic