Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Text tool by bold, italic, subscript and superscript support #339

Closed
AndreiMazol opened this issue Feb 19, 2021 · 3 comments · Fixed by #547
Closed

Extend Text tool by bold, italic, subscript and superscript support #339

AndreiMazol opened this issue Feb 19, 2021 · 3 comments · Fixed by #547
Assignees
@AndreiMazol @Svetlana-Asinovskaia
Labels
enhancement Priority: High
Milestone
Release 2.3.0

Comments

@AndreiMazol
Copy link
Contributor

It is necessary to enhance current plain text editor tool by adding the following functionality:

  • There is a possibility to change a style to bold and italic, make subscript and superscript
  • User can change the styles while text typing or/and by select a substring and applying styles
@AndreiMazol AndreiMazol self-assigned this Feb 19, 2021
@AndreiMazol AndreiMazol added enhancement Priority: High blocked Issue cannot be started while all dependencies are not resolved labels Feb 19, 2021
@AndreiMazol AndreiMazol added this to the Text tool (initial version) milestone Feb 19, 2021
@AndreiMazol
Copy link
Contributor Author

Issue blocked by #144

@mansuedei mansuedei self-assigned this Mar 11, 2021
@mansuedei mansuedei mentioned this issue Mar 12, 2021
Closed
@AndreiMazol AndreiMazol removed their assignment Mar 12, 2021
@AndreiMazol AndreiMazol removed the blocked Issue cannot be started while all dependencies are not resolved label Mar 12, 2021
@tomas-light tomas-light self-assigned this Mar 24, 2021
@tomas-light tomas-light removed their assignment Mar 25, 2021
@AndreiMazol AndreiMazol assigned StartsevDS and unassigned mansuedei Apr 7, 2021
StartsevDS added a commit that referenced this issue Apr 19, 2021
@StartsevDS
#339 add Draft.js library
5b3a1ef
@StartsevDS StartsevDS linked a pull request Apr 19, 2021 that will close this issue
#339 add Draft.js library #487
Closed
@AndreiMazol AndreiMazol modified the milestones: Text tool (initial version), Release 2.3.0 Apr 21, 2021
Closed
irinatelnova added a commit that referenced this issue May 7, 2021
@irinatelnova
Merge remote-tracking branch 'origin/#339-text-editor' into #339-expa…
91cbae1 
…nd-text-tool
irinatelnova added a commit that referenced this issue May 7, 2021
@irinatelnova
#339 Expand text tool
4f5da18
irinatelnova added a commit that referenced this issue May 7, 2021
@irinatelnova
#339-fix-conflicts
8520106
@irinatelnova irinatelnova linked a pull request May 7, 2021 that will close this issue
#339 expand text tool #504
Closed
@irinatelnova irinatelnova removed a link to a pull request May 7, 2021
#339 add Draft.js library #487
Closed
irinatelnova added a commit that referenced this issue May 11, 2021
@irinatelnova
#339 Fix multiline text render
5daa956
irinatelnova added a commit that referenced this issue May 11, 2021
@irinatelnova
#339-fix-multiline-text-render
bfd115d
@Svetlana-Asinovskaia
Copy link
Collaborator

Either subscript or superscript button should be selected at the same time.

Current behavior:
2021-05-18_17h35_33

@AndreiMazol AndreiMazol linked a pull request May 27, 2021 that will close this issue
#339 text tool enhancements #547
Merged
AndreiMazol added a commit that referenced this issue May 27, 2021
@AndreiMazol
#339 text tool enhancements (#547)
fc82432 
* add new icons

* rename label field to content

* add draft-js

* add text buttons

* save text content to ket

* update Text Control panel behavior
@Svetlana-Asinovskaia
Copy link
Collaborator

Release/2.3 The issue is verified and closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AndreiMazol AndreiMazol

@Svetlana-Asinovskaia Svetlana-Asinovskaia

Labels
enhancement Priority: High
Projects
None yet
Milestone
Release 2.3.0
Development

Successfully merging a pull request may close this issue.

#339 text tool enhancements epam/ketcher
#339 expand text tool epam/ketcher
6 participants
@tomas-light @mansuedei @AndreiMazol @irinatelnova @Svetlana-Asinovskaia @StartsevDS